Fork me on GitHub
#cljs-dev
<
2019-01-10
>
juhoteperi18:01:51

@thheller Any idea if this might be shadow-cljs issue: https://github.com/reagent-project/reagent/issues/420 ? The linked slack log points to a issue that you fixed previously

thheller18:01:11

@juhoteperi no you should be getting the same warning when running with externs inference turned on for normal CLJS + (set! *warn-on-infer* true)

juhoteperi18:01:40

Ah, okay. I wonder if I should set *warn-on-infer* on every file or what would be good way to ensure a library is compatible with infer externs?

thheller18:01:51

one test file that uses the with-let macro with infer-externs should be enough I guess

juhoteperi18:01:20

Reagent seems to have some other code that also causes problems

juhoteperi18:01:41

But I guess only problems in code generated from macros matter. Only code from macros might run in namespaces with *warn-on-infer* enabled.

thheller19:01:02

yeah. it is not a problem since we don't mind that closure is going to rename it. it just confuses the externs inference since it can't be sure.