Fork me on GitHub
#cljs-dev
<
2018-11-28
>
darwin01:11:21

Just heads up. It looks like I found a sourcemaps generation regression caused by https://github.com/clojure/clojurescript/commit/6cbd40f865132b8b13c6b902b715aed43e64f0b1 I upgraded dirac to 1.10.439 and some source-map-related tests started consistently failing, 1.10.339 is good, I was able to bisect it to the above offending commit, the whole thing is pretty complex and I don’t understand it fully yet, failing tests are testing https://github.com/binaryage/dirac/issues/53, didn’t get to comparing resulting sourcemaps, but it will be related to some local names missing or having wrong line/col info (e.g. culling “too much” as discussed in CLJS-2895). Hopefully I will get to investigating it further and prepare a proper JIRA ticket with some minimal repro case tomorrow.

darwin14:11:42

ok, described it as https://dev.clojure.org/jira/browse/CLJS-2993, it does not have a priority, but would be nice to have it fixed eventually