Clojurians
#cljs-dev
<
2018-11-02
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes12:11:23

Downstream, my main projects are all doing OK with current ClojureScript master.

mfikes14:11:32

A potential (non-regression) defect surrounding externs inference:

$ clj -m cljs.main -co '{:infer-externs true}' -r
ClojureScript 1.10.339
cljs.user=> (defn foo? [x y] (< x (or y (.-MAX_VALUE js/Number))))
WARNING: cljs.core/<, all arguments must be numbers, got [nil #{nil js/Number}] instead at line 1 <cljs repl>
If you don’t specify :infer-externs, then (.-MAX_VALUE js/Number) is inferred as type js and no warning is triggered. Alternatively, if you manually hint it with ^number then the warning goes away.

mfikes14:11:59

This one seems a bit unclear, so I’ll drop it in a JIRA where it can be investigated.

mfikes21:11:59

Hrm. I wonder if some npm deps are currently botched. ClojureScript tests that previously passed, now fail. Here is an example of re-running the latest passing test for master in CI: https://travis-ci.org/mfikes/clojurescript/builds/449630410

mfikes21:11:37

:facepalm:

dnolen21:11:12

trying locally

dnolen21:11:22

just started building 1.10.439

dnolen21:11:53

I don't see any failures

mfikes21:11:06

It is working again for me locally as well. (It was broken locally and in CI for perhaps an hour. Perhaps some glitch occurred that they cleared up quickly, so as to avoid another leftpad fiasco.)

mfikes21:11:23

I think the release notes for 1.10.439 are all in order. I’ll revise the date timestamp and put in the actual version number…

dnolen21:11:33

maybe we should post Monday morning?