Fork me on GitHub
#cljs-dev
<
2018-10-15
>
dnolen14:10:37

@potetm definitely might be a bug, I’ve never tested that flow myself either

mfikes14:10:52

I’m assuming that for :npm-deps, if you want the default behavior in the next release (indexing externally-supplied node_modules) you should specify :npm-deps {} and, in particular :npm-deps true is not legit. (There are unit tests like this, so this mode appears to work.) If we want the legal values to be boolean? and map? I can update https://github.com/clojure/clojurescript-site/pull/264

dnolen15:10:31

yes let’s expand that

thheller20:10:49

@dnolen I found a race condition in the CLJS compiler which you "accidentally" fixed recently via a perf opt. Not sure if its worth considering fixing this differently. See https://dev.clojure.org/jira/browse/CLJS-2922?focusedCommentId=50319&amp;page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-50319