A couple of tickets with 1-line patches that could be applied (since they only revise test code): https://dev.clojure.org/jira/browse/CLJS-2782 https://dev.clojure.org/jira/browse/CLJS-2915

thanks, testing

this one looks OK & useful https://dev.clojure.org/jira/browse/CLJS-2728

testing it

I’m AFK, but on the surface that patch looks like it only covers the self-hosted branch

I haven't had time to look into this - but I will try to - just wanted to gently vote for https://dev.clojure.org/jira/browse/CLJS-2793 it breaks all our instrumentation checks that are variadic

@mfikes thanks, good catch!

@richiardiandrea patch welcome for that one, not sure when I will get a chance to get that

is spec-ing variadic function good practice? asking because I am surprised not many people voted that one

and maybe I am missing something 😄

no that issue has come up multiple times but it seems there are still some missed cases

a lot of the challenges are just making it work under advanced compilation

Updated patch for CLJS-2728 operates correctly for JVM ClojureScript. I’m running it through some perf checks since it is inline with every macroexpand.

k thanks