Clojurians
#cljs-dev
<
2018-09-28
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes11:09:44

A couple of tickets with 1-line patches that could be applied (since they only revise test code): https://dev.clojure.org/jira/browse/CLJS-2782 https://dev.clojure.org/jira/browse/CLJS-2915

dnolen15:09:36

thanks, testing

dnolen16:09:23

testing it

mfikes16:09:19

I’m AFK, but on the surface that patch looks like it only covers the self-hosted branch

richiardiandrea17:09:49

I haven't had time to look into this - but I will try to - just wanted to gently vote for https://dev.clojure.org/jira/browse/CLJS-2793 it breaks all our instrumentation checks that are variadic

dnolen17:09:15

@mfikes thanks, good catch!

dnolen17:09:28

@richiardiandrea patch welcome for that one, not sure when I will get a chance to get that

richiardiandrea17:09:53

is spec-ing variadic function good practice? asking because I am surprised not many people voted that one

richiardiandrea17:09:01

and maybe I am missing something :smile:

dnolen18:09:32

no that issue has come up multiple times but it seems there are still some missed cases

dnolen18:09:20

a lot of the challenges are just making it work under advanced compilation

mfikes20:09:58

Updated patch for CLJS-2728 operates correctly for JVM ClojureScript. I’m running it through some perf checks since it is inline with every macroexpand.