using latest master I have FAILs on the tests

Hmm. Master is currently OK in CI https://github.com/mfikes/clojurescript/commits/master Will try locally.

What version of NPM are you running @raymcdermott?

5.6.0

OK, I'm running 5.6.0 as well, and node v8.11.3

node 9.7.1

Hmm. I recall some problems with Node 9 even in another ClojureScript project I was running. Let me try that with ClojureScript's tests.

thanks

the versions of these (npm and node) are not mentioned anywhere in the pre-requisites

Right. The only problem I'm aware of is one that occurs with an ancient version of NPM / Node https://dev.clojure.org/jira/browse/CLJS-2878 And I had assumed my Node 9 problems may have been related to something half-baked in Node 9. (I think Node 8 and 10 worked for me IIRC.)

Hrm. I can't repro any failures locally

$ node --version
v9.7.1
$ npm -version
5.6.0
$ lein test :only cljs.module-processing-tests

lein test cljs.module-processing-tests

Ran 5 tests containing 14 assertions.
0 failures, 0 errors.

I get the same results with node v10.10.0

@raymcdermott You are experiencing https://dev.clojure.org/jira/browse/CLJS-2703 A workaround it to check out the compiler into a directory that doesn't have any hyphens in its name.

LOL ok

It is not exactly CLJS-2703, but close. New ticket: https://dev.clojure.org/jira/browse/CLJS-2914

ok, rebuilding / re-running

I hope that periods in the path are OK

with a period, 9 fails

so it’s going really well

Probably worth a JIRA

I’ll first check if simple paths work

ok, works with simple paths

I’ll redo with periods and open a ticket

https://dev.clojure.org/jira/browse/CLJS-2915

and that’s blown my time budget for the first foray into CLJS development

at least we got a ticket out of it

do you want me to add a small note of caution to the Dev build instructions?

(for example *ensure the directory path has no special chars including ‘.’ and ‘-’)

My opinion: We can just fix the bug

sure

that’s better

(It will probably be vanquished shortly)

coolio

(It probably affects more than just compiler devs... in that it could affect any ClojureScript project that has a dot in its name)

@mfikes Looking through the cljs/newbie-friendly tasks. Quite a few of the older ones have patches that no longer apply.

If I find tickets like that, I usually leave a comment that the patch no longer applies.

Yes, those are the ones I’m referring to 🙂

So I’m wondering is there a magic incantation to make the patch apply and still keep attribution?

Or is it up to the author of the patch to create a new one?

Those are open questions in my mind, especially in the case of non-trivial patches. But for newbie tickets may be easy to create new patches. Another concern is the case when the patch author hasn’t signed the CA.

I guess for the last case, I understand one should do a clean room reimplementation of the patch, right?

Definitely. You don’t want to derive a patch from a patch authored by someone who hasn’t signed the CA.

(I suppose ideally you wouldn’t even review such patches.)

^^

Many of my inchoate thoughts about the recent type inference stuff I've been brewing up were captured in a discussion with Daniel Compton https://therepl.net/episodes/3/

(I think the type inference part is the first 20 minutes or so IIRC.)

Sorry, nothing on topic here. Just had fun noticing that "inchoate" is a so-called "unpaired word", i.e. "choate" isn't a word that means the opposite of "inchoate". Humorous article "How I Met My Wife" is an exercise in using many of these all in one short story: https://www.newyorker.com/magazine/1994/07/25/how-i-met-my-wife