If we start thinking about a release, here is the draft release notes: https://github.com/clojure/clojurescript-site/pull/244

no other perf tickets to review right?

No, I think all of the perf tickets have landed on master.

Oh, I suppose there are optimizations that take advantage of type hints, but perhaps those shouldn't be rushed.

yeah I think we should hold off on that

fast REPL prompt is nicer UX, just tested that

Cool 🙂

Some unit test failing to perhaps clean up: https://github.com/mfikes/clojurescript/commits/master

ah yeah, checking

what is core.async supposed to do with the js* special form ?

@mfikes looking at the backlog, yeah so that’s just a bad core.async bug

core.async appears to have a way to identify if something needs special-override? and if so, it leaves the form alone. Maybe it is as simple as adding js* to that logic. Just a guess from a quick reading.

At least that prevents expansion. The real problem is let-binding things being passed to js* and evaluating those bits.

But, yeah, not really a ClojureScript issue, it is a bad assumption being made by core.async.

someone is using 1.10.339 and just got a static compile warning about type errors in #figwheel-main if you want a data point @mfikes

@dpsutton What is this with respect to?

with your type inference additions

Hrm. None of my type inference stuff is in 1.10.339

oh my bad. i thought some had made it. apologies 🙂

Hmm. It makes me curious as to what they were seeing.

it surprised bhauman as well who asked which compiler he/she was using

Oh sorry @dpsutton I’m being dense and didn’t realize you were referring to the channel, not the library.

ah yes. they are discussing it in that channel. bruce is helping someone work through some issues and that warning came up

Yeah, the typechecks on <= have been there forever 🙂

well the are cool none the less

@bhauman If we end up with this, the coolness will go to 11: https://gist.github.com/mfikes/1e2341b48b882587500547f6ba19279d

yeah I saw that!!

@mfikes I’m only seeing one failure locally, does that seem right to you? re: :npm-deps change

I’ll give it a spin locally as well. (In meetings and such so may be delayed.)

Also working on fixing a regression https://dev.clojure.org/jira/browse/CLJS-2906

I get one failure when running lein test. Unable to dig meaningfully into it. Here is my local repro: https://gist.github.com/mfikes/9643684a4d076c0bdd29db9967cf0559

(Will look when free.)

yep I believe resolved with the last push to master

Confirmed that this fails without latest commit, but passes with it

lein test :only cljs.build-api-tests/test-node-modules-cljs-2246

Updated https://dev.clojure.org/jira/browse/CLJS-2906 to blocker so we don’t miss it

fixing that now

Cool. Your fix is more robust 🙂

Release notes are in decent shape now https://github.com/clojure/clojurescript-site/blob/7b5463d3455037492484d9d0d4fcb83db5d90b82/content/news/2018-09-01-release.adoc

Has anybody every seen

Sep 14, 2018 11:12:32 AM com.google.javascript.jscomp.LoggerErrorManager println
SEVERE: /home/arichiardi/git/hal-clj/target/cljs/core.js:3321: ERROR - Parse error. primary expression expected
case ##Inf:
      ^

Sep 14, 2018 11:12:32 AM com.google.javascript.jscomp.LoggerErrorManager printSummary
WARNING: 1 error(s), 0 warning(s)
ERROR: JSC_PARSE_ERROR. Parse error. primary expression expected at /home/arichiardi/git/hal-clj/target/cljs/core.js line 3321 : 6
... done. Elapsed 12.090197018 seconds

Yes. But it drives me crazy that we can't just search the Slack archives for the answer. 😞

@richiardiandrea Got lucky on that one: https://dev.clojure.org/jira/browse/CLJS-2352

oh sorry I tried to google...

weird I am on 1.10.339

the patch should be in

Maybe its not that then

ok will dig a bit thanks!

It was discussed here https://clojurians-log.clojureverse.org/clojurescript/2017-09-22

uhm yeah it looks like I am not including the right dep: // Compiled by ClojureScript 1.9.229 {:static-fns true, :optimize-constants true}

thanks a lot

another question that I was interested in is whether deps.cljs is at the moment read from :local/root dependencies by any chance

i can try of course 😉

in theory I do not see why not if the classpath includes a local folder

Quick Start is currently OK with 1.10.421 built from master