Clojurians
#cljs-dev
<
2018-09-14
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes00:09:57

If we start thinking about a release, here is the draft release notes: https://github.com/clojure/clojurescript-site/pull/244

dnolen12:09:20

no other perf tickets to review right?

mfikes12:09:36

No, I think all of the perf tickets have landed on master.

mfikes12:09:39

Oh, I suppose there are optimizations that take advantage of type hints, but perhaps those shouldn't be rushed.

dnolen12:09:20

yeah I think we should hold off on that

dnolen12:09:50

fast REPL prompt is nicer UX, just tested that

mfikes12:09:11

Cool :slightly_smiling_face:

dnolen13:09:08

ah yeah, checking

leonoel13:09:05

what is core.async supposed to do with the js* special form ?

dnolen13:09:10

@mfikes looking at the backlog, yeah so that’s just a bad core.async bug

mfikes13:09:30

core.async appears to have a way to identify if something needs special-override? and if so, it leaves the form alone. Maybe it is as simple as adding js* to that logic. Just a guess from a quick reading.

mfikes13:09:21

At least that prevents expansion. The real problem is let-binding things being passed to js* and evaluating those bits.

mfikes13:09:52

But, yeah, not really a ClojureScript issue, it is a bad assumption being made by core.async.

dpsutton13:09:24

someone is using 1.10.339 and just got a static compile warning about type errors in #figwheel-main if you want a data point @mfikes

mfikes13:09:15

@dpsutton What is this with respect to?

dpsutton13:09:27

with your type inference additions

mfikes13:09:04

Hrm. None of my type inference stuff is in 1.10.339

dpsutton13:09:34

oh my bad. i thought some had made it. apologies :slightly_smiling_face:

mfikes13:09:59

Hmm. It makes me curious as to what they were seeing.

dpsutton13:09:19

it surprised bhauman as well who asked which compiler he/she was using

mfikes13:09:12

Oh sorry @dpsutton I’m being dense and didn’t realize you were referring to the channel, not the library.

dpsutton13:09:41

ah yes. they are discussing it in that channel. bruce is helping someone work through some issues and that warning came up

mfikes13:09:32

Yeah, the typechecks on <= have been there forever :slightly_smiling_face:

bhauman13:09:34

well the are cool none the less

mfikes13:09:49

@bhauman If we end up with this, the coolness will go to 11: https://gist.github.com/mfikes/1e2341b48b882587500547f6ba19279d

bhauman13:09:40

yeah I saw that!!

dnolen14:09:19

@mfikes I’m only seeing one failure locally, does that seem right to you? re: :npm-deps change

mfikes14:09:55

I’ll give it a spin locally as well. (In meetings and such so may be delayed.)

mfikes14:09:08

I get one failure when running lein test. Unable to dig meaningfully into it. Here is my local repro: https://gist.github.com/mfikes/9643684a4d076c0bdd29db9967cf0559

mfikes14:09:18

(Will look when free.)

dnolen15:09:02

yep I believe resolved with the last push to master

mfikes15:09:42

Confirmed that this fails without latest commit, but passes with it

lein test :only cljs.build-api-tests/test-node-modules-cljs-2246

mfikes15:09:47

Updated https://dev.clojure.org/jira/browse/CLJS-2906 to blocker so we don’t miss it

dnolen17:09:02

fixing that now

mfikes17:09:06

Cool. Your fix is more robust :slightly_smiling_face:

richiardiandrea18:09:06

Has anybody every seen

Sep 14, 2018 11:12:32 AM com.google.javascript.jscomp.LoggerErrorManager println
SEVERE: /home/arichiardi/git/hal-clj/target/cljs/core.js:3321: ERROR - Parse error. primary expression expected
case ##Inf:
      ^

Sep 14, 2018 11:12:32 AM com.google.javascript.jscomp.LoggerErrorManager printSummary
WARNING: 1 error(s), 0 warning(s)
ERROR: JSC_PARSE_ERROR. Parse error. primary expression expected at /home/arichiardi/git/hal-clj/target/cljs/core.js line 3321 : 6
... done. Elapsed 12.090197018 seconds

mfikes18:09:07

Yes. But it drives me crazy that we can't just search the Slack archives for the answer. :disappointed:

mfikes18:09:36

@richiardiandrea Got lucky on that one: https://dev.clojure.org/jira/browse/CLJS-2352

richiardiandrea18:09:59

oh sorry I tried to google...

richiardiandrea18:09:11

weird I am on 1.10.339

richiardiandrea18:09:16

the patch should be in

mfikes18:09:22

Maybe its not that then

richiardiandrea18:09:43

ok will dig a bit thanks!

richiardiandrea18:09:22

uhm yeah it looks like I am not including the right dep: // Compiled by ClojureScript 1.9.229 {:static-fns true, :optimize-constants true}

richiardiandrea18:09:14

another question that I was interested in is whether deps.cljs is at the moment read from :local/root dependencies by any chance

richiardiandrea18:09:36

i can try of course :wink:

richiardiandrea18:09:20

in theory I do not see why not if the classpath includes a local folder

mfikes20:09:16

Quick Start is currently OK with 1.10.421 built from master