Clojurians
#cljs-dev
<
2018-08-24
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen21:08:39

@mfikes will look at those soon, decided to take some time today to look at YourKit

dnolen21:08:54

looks like we at the point where just piling up some micropts would make a difference

mfikes21:08:56

Thanks. No rush.

dnolen21:08:43

one issue is that even one run compiling cljs.core with the sampling profiler creates a snapshot that eats up 12+ gb of RAM :stuck_out_tongue:

dnolen21:08:10

so this is a bit tedious, but even a couple tweaks I made based on that is shaving off 100ms here, 100ms there

thheller22:08:00

@dnolen if you are out benchmarking I still have this one tweak on my benchmark to-do list which seems to make a difference overall. basically just checking (string? x) here so it skips the print-str call. string is the most common path for emits. https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/compiler.cljc#L204

dnolen22:08:38

hrm tools.reader is failing to download for me when trying to bootstrap

dnolen22:08:16

hrm maybe central is down?

dnolen22:08:38

hrm this might be a good time to say good bye to bootstrap script

dnolen22:08:42

and just use deps.edn

dnolen22:08:05

ah but maven central is down it seems - ok done for the day then :slightly_smiling_face:

dnolen22:08:50

hrm I guess should leave this alone for now - windows users

dnolen22:08:58

but will add build.edn

dnolen22:08:04

have to run for now but I think I spotted some other perf wins, will have to try later

mfikes22:08:30

A lot of this recent inference stuff I’ve been doing has the potential to slow down compilation if my patches weren’t careful. I think I’ll take another look at them with perf in mind.