Clojurians
#cljs-dev
<
2018-07-16
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

juhoteperi15:07:04

Recent global-exports change in 312+ broke cases where the value contains dots, when trying to point to property inside main object: https://github.com/clojure/clojurescript/commit/3b0ce12d4c7e4a8ba9321531509490710d733662 E.g.

:global-exports '{react-transition-group ReactTransitionGroup
                                react-transition-group/Transition ReactTransitionGroup.Transition
                                react-transition-group/TransitionGroup ReactTransitionGroup.TransitionGroup
                                react-transition-group/CSSTransitionGroup ReactTransitionGroup.CSSTransitionGroup})

juhoteperi15:07:40

Ideas if we should support this and how? Split value on dots and emit bracket access for each part?

juhoteperi15:07:36

I find this useful (and necessary) for providing global-exports which mimic the node module names

dnolen15:07:23

@juhoteperi I’m ok with that

dnolen15:07:34

patch welcome

juhoteperi16:07:42

@dnolen Patch added

juhoteperi17:07:08

I've taken a quick look at MaterialUI node module support and I think we have at least two bugs on our side affecting this, 1. we need support for ignoring modules using package.json main-entry (browser entry) fields (related: CLJS-2816), I have a good idea how to implement this, 2. something is breaking requires between some cjs/es6 modules, it could be due to our provide/require calls

juhoteperi17:07:42

I try take a better look at this this week so I can write proper issues and maybe work on fixes