Clojurians
#cljs-dev
<
2018-06-15
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes11:06:17

https://dev.clojure.org/jira/browse/CLJS-2778 may need to be looked at prior to release (at least to decide if it is a non-issue)

juhoteperi11:06:10

Looking at the change, the test case should be fixed to use goog.global["ReactDOMServer"]

mfikes11:06:22

There is also https://dev.clojure.org/jira/browse/CLJS-2779, which may in fact be related to the same underlying root issue

mfikes12:06:59

Kicking off a Canary build to ensure all is good there.

mfikes12:06:12

I had started drafting this compilation of relevant doc PRs https://gist.github.com/mfikes/b457cb5d850af87d5047d1ac0c99c6d6 The Git Deps revision to the :aot-cache docs isn't yet relevant (because it is currently disabled until we figure out https://dev.clojure.org/jira/browse/CLJS-2765) As an aside, I've been wondering if using some sort of label like "next release" would be easier to manage for clojurescript-site PRs that are pending a ClojureScript release.

dnolen12:06:37

@mfikes Canary looking ok? Or does that take a bit to run

mfikes12:06:55

Yes, Canary is still running. The only failure in last night's run was closure-latest which was CLJS-2765. That particular project is currently running here https://travis-ci.org/mfikes/closure-latest

dnolen12:06:51

@mfikes sorry maybe I’m missing something - does that failure require us to do anything?

darwin12:06:54

btw. current canary jobs can be also viewed from commit list in “jobs” branch via github: https://github.com/cljs-oss/canary/commits/jobs

mfikes12:06:22

@dnolen No... and I expect with your latest commits, Canary will go all green

mfikes12:06:30

Canary is green across the board now https://github.com/cljs-oss/canary

dnolen12:06:35

@pesterhazy thanks fixed in my PR now

dnolen12:06:54

k building / releasing 1.10.312 now

dnolen12:06:49

@mfikes I just pushed the webpack guide, let me know when the other ones are ready and I can review and then we can announce on the various channels

mfikes12:06:56

OK, I'm working on the "1.10.312 Release" news post

dnolen12:06:30

Definitely make sure to mention the externs inference fixes and link to the new guide on using Webpack

mfikes12:06:06

Yeah, that's the main bit of extra copy I'm thinking of

mfikes12:06:53

Here is a "live" link to the news post https://github.com/clojure/clojurescript-site/blob/mid-2018-release/content/news/2018-06-15-release.adoc I'm thinking of (apart from any general copy edits for correctness and checking that the Contributors list is correct), adding the stuff David just mentioned above

mfikes13:06:36

(I'm thinking there might be other features worth touting; will check the commit log)

dnolen13:06:15

312 post looks good, I think improved externs inference + :global-exports is the big story :slightly_smiling_face:

wcohen13:06:48

do you all have guidance for when to use the webpack-bundle approach versus individually including npm dependencies and trying to get externs to work one by one?

dnolen13:06:02

@wcohen don’t do the later? :slightly_smiling_face:

mfikes13:06:08

I've updated the externs section of the release notes to point to the webpack guide

dnolen13:06:21

@mfikes that’s actually fine

dnolen13:06:57

I think that post is good - I say ship it

mfikes13:06:00

Cool. https://github.com/clojure/clojurescript-site/pull/231 might be ready unless anyone sees any changes needed

mfikes13:06:40

Cool. Looking for any other relevant doc PRs...

dnolen13:06:54

yeah merging them

dnolen13:06:58

:elide-strict has conflicts

mfikes13:06:06

OK, will resolve them

mfikes14:06:55

:elide-strict conflicts have been resolved

dnolen14:06:44

@mfikes #235 #233 aren’t implemented yet right?

dnolen14:06:01

I added an incomplete tag, we should mark stuff that’s not done yet

mfikes14:06:05

@dnolen Right. They are essentially documentation to accommodate patches in tickets that haven't yet been merged. (Perhaps if we add new labels there could be a label to mark things

mfikes14:06:14

I've added "incomplete" to those two PRs

dnolen17:06:31

@mfikes might also help to link to the issues? I can’t find the user.cljs|cljc one

mfikes17:06:53

Yeah... I can do that.

dnolen17:06:15

looks like we’re getting some motion on the scoped npm module issue :slightly_smiling_face:

mfikes22:06:06

Hah! ClojureScript News is now almost 1 year old. https://clojurescript.org/news/2017-06-26-welcome