Clojurians
#cljs-dev
<
2018-06-14
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen00:06:39

externs inference should be greatly improved now

dnolen16:06:12

going to cut a release tomorrow - if there’s something you want to see in the release let me know

juhoteperi16:06:22

@dnolen I think this quite important closure fix is present in latest release: https://github.com/google/closure-compiler/pull/2963/commits/5950afe8f9ed964616bc07867c6afeb85caf3f85 (it should fix React 16 CJS wrappers)

juhoteperi16:06:36

I'll test Cljs with latest Closure & send patch if it works

dnolen16:06:49

@juhoteperi ah bump Closure - ok, thanks!

juhoteperi16:06:34

Cljs tests pass but I'm having some problems with Reagent, investigating

juhoteperi16:06:00

The problem is not caused by Closure update but is present with current master

juhoteperi17:06:58

Several namespaces in Reagent are broken after this merge: https://github.com/clojure/clojurescript/commit/fed0807f75c86cd8aaeedd4fe6702b8790e7a31a one example is https://github.com/reagent-project/reagent/blob/master/src/reagent/debug.cljs#L10-L18 but after I commented this out I got same error from another ns

dnolen17:06:19

Seems strange, the error wrt. to the commit

dnolen17:06:27

@juhoteperi need to reduce the scope of that - just not enough information

juhoteperi17:06:36

Huh it started working

dnolen17:06:07

yeah it looks like an environment problem to me

juhoteperi17:06:16

Maybe I had bad class files in ClojureScript target folder which persisted even through bisect

juhoteperi17:06:48

Should have remembered to start by cleaning target folder. Anyway I can now confirm Reagent correctly uses React dev build with npm-deps, previously it always used production file which didn't have proper error messages and broke React dev tools.

dnolen17:06:05

@juhoteperi applied