This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-06-14
Channels
- # beginners (183)
- # boot (6)
- # cider (106)
- # cljs-dev (17)
- # cljsjs (2)
- # cljsrn (2)
- # clojure (56)
- # clojure-italy (14)
- # clojure-nl (39)
- # clojure-spec (49)
- # clojure-uk (138)
- # clojurescript (197)
- # core-logic (37)
- # cursive (22)
- # datascript (5)
- # datomic (29)
- # devcards (18)
- # emacs (1)
- # events (8)
- # figwheel (1)
- # fulcro (59)
- # lein-figwheel (1)
- # leiningen (1)
- # off-topic (54)
- # onyx (3)
- # pedestal (1)
- # portkey (4)
- # re-frame (18)
- # reagent (5)
- # reitit (43)
- # ring (6)
- # ring-swagger (26)
- # shadow-cljs (42)
- # spacemacs (8)
- # specter (12)
- # sql (3)
- # tools-deps (21)
- # vim (18)
going to cut a release tomorrow - if there’s something you want to see in the release let me know
@dnolen I think this quite important closure fix is present in latest release: https://github.com/google/closure-compiler/pull/2963/commits/5950afe8f9ed964616bc07867c6afeb85caf3f85 (it should fix React 16 CJS wrappers)
I'll test Cljs with latest Closure & send patch if it works
@juhoteperi ah bump Closure - ok, thanks!
Cljs tests pass but I'm having some problems with Reagent, investigating
The problem is not caused by Closure update but is present with current master
Several namespaces in Reagent are broken after this merge: https://github.com/clojure/clojurescript/commit/fed0807f75c86cd8aaeedd4fe6702b8790e7a31a one example is https://github.com/reagent-project/reagent/blob/master/src/reagent/debug.cljs#L10-L18 but after I commented this out I got same error from another ns
@juhoteperi need to reduce the scope of that - just not enough information
Huh it started working
Maybe I had bad class files in ClojureScript target folder which persisted even through bisect
Should have remembered to start by cleaning target folder. Anyway I can now confirm Reagent correctly uses React dev build with npm-deps, previously it always used production file which didn't have proper error messages and broke React dev tools.
@juhoteperi applied