Fork me on GitHub
#cljs-dev
<
2018-05-01
>
mfikes02:05:14

Looking into https://dev.clojure.org/jira/browse/CLJS-2702 a little; it looks like it is trivial to recover most of the functionality by continuing to work with Closure Library private API (and while retaining compatibility with the older private API), but some of the corner cases will be a little more difficult to reach and will take more digging. If curious: https://github.com/mfikes/clojurescript/commit/7f832ec13090a495983e52c1cd3b9d02ef937447?w=1

anmonteiro02:05:29

it works because we run a module resolver that is aware of the resolution context

richiardiandrea02:05:22

Ok that starts to make sense, thanks for the tip, I guess I will find it in the module-deps.js script

richiardiandrea16:05:09

Other question related to that, I wonder why the module-deps.js is launched with node --eval? Why don't we pass cli parameters?

juhoteperi16:05:36

@richiardiandrea I don't understand the second question, but: module-deps.js file doesn't necessarily exist in filesystem so eval is easy way to run the code without first writing it to some file

richiardiandrea16:05:49

oh got it, yeah so it is run from an in-memory string that is why

juhoteperi16:05:10

Usually the original file is inside jar and node wouldn't know about those

richiardiandrea16:05:20

I though it was saved to disk first in some temp folder