Fork me on GitHub
#cljs-dev
<
2018-04-28
>
richiardiandrea00:04:57

just put here, kind of focused on lumo now, will try to contribute a fix

richiardiandrea01:04:54

it seems the behavior of enable-console-print! changed a bit, I see it here: https://github.com/clojure/clojurescript/commit/517f3d8876f90a1bebb2dc0bffbc926297226ea1

richiardiandrea01:04:23

that is probably why now lumo's *print-newline* is always false....still kind of need to understand better though

richiardiandrea01:04:16

the result is this:

lumo.build-api-tests=> (enable-console-print!)

lumo.build-api-tests=> (do (println "tare") (println "ars"))
tarearsnil

mfikes01:04:58

@richiardiandrea In case it helps, Planck also made a tweak to fix up newline behavior https://github.com/planck-repl/planck/issues/638

mfikes01:04:52

Unlikely the same exact scenario for Lumo, but sharing nonetheless.

richiardiandrea01:04:05

got it, yes I think that will help

richiardiandrea01:04:21

thanks for sharing

mfikes01:04:55

IIRC in Planck's case it was more a matter of initialization order to ensure that Planck's printing was in place at the right time.

richiardiandrea01:04:24

yes probably that is the same, before the init was done for us, but that commit changes things a bit

mfikes16:04:08

I'm curious, does anyone know if GraalJS is a completely new JavaScript engine. It seems different than Detroit.

mfikes16:04:36

(If it is new, I'm wondering if we can add support for it in our unit test suite, as another engine to run the test upon.)

mfikes17:04:56

Whatever that engine is, it is faster than Nashorn, but slower than the other modern engines.

mfikes17:04:46

I've added https://dev.clojure.org/jira/browse/CLJS-2745 and will probably take care of it, since it seems straightforward to do. For those that want to opt into testing with GraalVM it would be based on whether GRAALVM_HOME is set, just like the other engines.

mfikes18:04:52

I found an answer to where Graal.js came from: "Graal.js contains code derived from OpenJDK Nashorn, Node.js, and V8." (https://github.com/graalvm/graaljs#attribution)

mfikes19:04:14

Nice, the GraalVM project lead responded with an interest in our perf: https://twitter.com/thomaswue/status/990308498373300228

👍 4
john14:05:52

were you trying to compile cljs.main into self-hosted cljs executable that could quickly interpret *.cljs files?