while updating lumo I have noticed there are two tests in build_api_tests.clj with the same name https://github.com/clojure/clojurescript/blob/233b42338c182e72391466eba2d00bae34271e58/src/test/clojure/cljs/build_api_tests.clj#L150

just put here, kind of focused on lumo now, will try to contribute a fix

it seems the behavior of enable-console-print! changed a bit, I see it here: https://github.com/clojure/clojurescript/commit/517f3d8876f90a1bebb2dc0bffbc926297226ea1

that is probably why now lumo's *print-newline* is always false....still kind of need to understand better though

the result is this:

lumo.build-api-tests=> (enable-console-print!)

lumo.build-api-tests=> (do (println "tare") (println "ars"))
tarearsnil

@richiardiandrea In case it helps, Planck also made a tweak to fix up newline behavior https://github.com/planck-repl/planck/issues/638

Unlikely the same exact scenario for Lumo, but sharing nonetheless.

got it, yes I think that will help

thanks for sharing

IIRC in Planck's case it was more a matter of initialization order to ensure that Planck's printing was in place at the right time.

yes probably that is the same, before the init was done for us, but that commit changes things a bit

Oh, and you can see I literally made it add newlines with that bit here https://github.com/planck-repl/planck/commit/3445dd7f9f3c3a13632bd5e92433959b7c1d2770#diff-55618d2988c90febd96d13df09826633R683

I'm curious, does anyone know if GraalJS is a completely new JavaScript engine. It seems different than Detroit.

(If it is new, I'm wondering if we can add support for it in our unit test suite, as another engine to run the test upon.)

https://github.com/graalvm/graaljs

FWIW, the tests pass https://gist.github.com/mfikes/f38132afab68d82a9e415179e8101bcd

Whatever that engine is, it is faster than Nashorn, but slower than the other modern engines.

https://twitter.com/mfikes/status/990278534827511808

I've added https://dev.clojure.org/jira/browse/CLJS-2745 and will probably take care of it, since it seems straightforward to do. For those that want to opt into testing with GraalVM it would be based on whether GRAALVM_HOME is set, just like the other engines.

I found an answer to where Graal.js came from: "Graal.js contains code derived from OpenJDK Nashorn, Node.js, and V8." (https://github.com/graalvm/graaljs#attribution)

Nice, the GraalVM project lead responded with an interest in our perf: https://twitter.com/thomaswue/status/990308498373300228