This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-04-07
Channels
- # beginners (166)
- # cider (6)
- # cljs-dev (12)
- # cljsrn (64)
- # clojure (71)
- # clojure-chicago (1)
- # clojure-spec (14)
- # clojure-uk (2)
- # clojurescript (25)
- # datomic (2)
- # docs (1)
- # duct (1)
- # emacs (4)
- # fulcro (5)
- # graphql (3)
- # java (46)
- # mount (5)
- # off-topic (29)
- # onyx (1)
- # portkey (10)
- # re-frame (12)
- # remote-jobs (1)
- # shadow-cljs (46)
- # spacemacs (1)
- # specter (4)
- # vim (2)
I see there’s module_wrapper
flag in Closure. Does cljs recognize this option? Can’t see any references in the source.
Ok, :rename-prefix
option solves the issue. Though :rename-prefix-namespace
in conjunction with module_wrapper
should enable renaming of the prefix within wrapper function https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/RescopeGlobalSymbols.java#L31-L54 @dnolen I think it worth documenting :rename-prefix
option, I’ll submit a pr
Windows summary: I think all of the test failures now have fixes (CLJS-2713, CLJS-2721, and CLJS-2726). (This puts us in a good position to catch Windows regressions, as I’ll get emailed if the build fails.)
The only other unsolved testing-related issue I’m aware of is https://dev.clojure.org/jira/browse/CLJS-2703
(This prevents us from running lein with-profile +closure-snapshot test
in the closure-latest
Canary test, simply because that repo has a hyphen in its name.)
@mfikes Looks like problem with the test cases. In compile output -
is replaced with _
which is correct with module names.
Or is it. Hmm.
I think it is correct. Goog.provide and require names are generated by Closure-compiler method.
Probably the absolute-module-path
test util should replace -
in paths with _
here: https://github.com/clojure/clojurescript/blob/master/src/test/clojure/cljs/module_processing_tests.clj#L35
Not sure what is going on with filename
binding where _
is replaced with -