Clojurians
#cljs-dev
<
2018-04-07
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

roman01la00:04:38

I see there’s module_wrapper flag in Closure. Does cljs recognize this option? Can’t see any references in the source.

roman01la08:04:20

Ok, :rename-prefix option solves the issue. Though :rename-prefix-namespace in conjunction with module_wrapper should enable renaming of the prefix within wrapper function https://github.com/google/closure-compiler/blob/master/src/com/google/javascript/jscomp/RescopeGlobalSymbols.java#L31-L54 @dnolen I think it worth documenting :rename-prefix option, I’ll submit a pr

dnolen19:04:43

sounds good

mfikes20:04:35

Windows summary: I think all of the test failures now have fixes (CLJS-2713, CLJS-2721, and CLJS-2726). (This puts us in a good position to catch Windows regressions, as I’ll get emailed if the build fails.)

mfikes20:04:10

The only other unsolved testing-related issue I’m aware of is https://dev.clojure.org/jira/browse/CLJS-2703 (This prevents us from running lein with-profile +closure-snapshot test in the closure-latest Canary test, simply because that repo has a hyphen in its name.)

juhoteperi20:04:23

@mfikes Looks like problem with the test cases. In compile output - is replaced with _ which is correct with module names.

juhoteperi20:04:18

Or is it. Hmm.

juhoteperi20:04:28

I think it is correct. Goog.provide and require names are generated by Closure-compiler method.

juhoteperi20:04:54

Probably the absolute-module-path test util should replace - in paths with _ here: https://github.com/clojure/clojurescript/blob/master/src/test/clojure/cljs/module_processing_tests.clj#L35

juhoteperi20:04:14

Not sure what is going on with filename binding where _ is replaced with -

mfikes20:04:06

OK, I can give that a shot.

mfikes20:04:15

Yep. Good call Juho. Putting together a patch with that tweak.