as long as the thread is run with bindings in place it will work

I think threads are inheriting out like david said

(OK, I don't truly understand the problem anyway.)

because it’s the same *out* as the initiating process

but it wouldn’t be if you didn’t propagate bindings

REPL evals are working, as well as prns

cool

By the way, lein --version reports 2.8.1 for me. I think I updated it when I ran into a Java 9 issue

👏

browser REPL seems to be working with the piggiehack as well

lol

piggiehack

Sorry, not cool to use pejorative terms, but it was irresitable.

anyhoo I think this is fine for now

Yep

Emacs users can sleep easy

@ghopper thanks for the report, sounds like this is probably fixed in master

Oh, I finally get what you were saying earlier, David about the 50%. Yeah. Lots of people use stuff but never roll up their sleeves to fix it.

My pet peeve is people complaining about docs, but not contributing to those docs.

well, I would summarize as some people have very distorted notion of the labor distribution wrt. contribution in the Clojure ecosystem

Maya Angelou: "What you're supposed to do when you don't like a thing is change it. If you can't change it, change the way you think about it. Don't complain."

I think ClojureScript itself is doing pretty well

Yeah, one thing I have noticed is this notion that there is this "big" core team contributing to ClojureScript.

haha

right we have lots of contributors - but the number of outlying tasks far exceeds what we can deal with in a timely manner

and testing ClojureScript is a PITA

due to all the environmental issues

Well, it is easier with cljs.main 🙂

so seemingly simple changes often aren’t

right it helps - but we have an heterogenous environment issue that Clojure doesn’t

Right, the problem where you aren't sure if you broke some corner case for some wierd situation.

but still I don’t think ClojureScript itself has much to complain about

but the external tooling story doesn’t seem that great to me, especially critical stuff

to be fair it’s thankless work

this new stuff will make that better

which I is why I think folding it in, and getting people to use the standard stuff is way forward in the long run

but this meme that the “community” can do it better

zero evidence

and it’s been 10+ years

Yeah, there is a lot of truth in that

which is just to say the Rich Hickey way is not bad

Lots of folks would vote to fold things in

it's just how much y'all want to maintain

@john well you get difference of opinions about that of course

but no we don’t want to maintain sugar-y stuff for the most part

linting, prettier error messages, etc.

I'm trying to think back, what was the motivation for cljs.main. Was it always in the back of your mind? Was it clj that finally made it make a lot of sense? Hmm.

I think I was just irritated that we didn’t have basic Clojure stuff

and then when I started on it I realized this would fix a lot of problems

for myself, for testers, and for newcomers

when did that start?

cljs.main idea is actually a pretty old ticket

When you ask: What's next for ClojureScript? Half a year ago you couln't have predicted cljs.main was part of what was going to happen.

pretty sure 1NNN

It actually seems to have ended up being more useful that I initally thought.

but looking back I think that before

cljsbuild etc. seemed fine - and of course they will continue to be needed useful etc.

but after spending a lot of time with these tools I think it dawned on me there was some benefit to just have ClojureScript do it out of the box

and now I think it’s ended up becoming a baseline for user experience

Right now, without it having been released yet, it is difficult to predict what the uptake of cljs.main will be. Will it be a flop and forgotten? Or will it take over the ClojureScript world? Of course somewhere in between is the answer, but it is hard to predict what it will be. 🙂

to be fair - planck, lumo, shadow-cljs had a lot of these affordances already

but I didn’t really look too closely - just wanted to simulate Clojure

One thing is crystal clear. The new user Quick Start is much cleaner, and less intimidating and cruft free now.

yes

I don’t think cljs.main will supplant existing tooling anytime soon

https://twitter.com/petterik_/status/976116775388672000

but also I don’t think it’s hard for people switch either if they are so inclined

Yeah, I put that tweet in the talk I gave 🙂

clj won't be replacing lein at work for a while, until we figure out ways to migrate our project files over

I know consuming project.clj is something that’s being talked aobut

Yeah, Alex said something like "it is very easy to do it poorly"

but in anycase, cljs.main is an investment in the future

Just seeing a full pedestal stack on it would be interesting

I don't know, I'm hoping some time in 2018, I can start all projects with just clj/deps.edn/cljs.main things

Some of the private repo stuff is coming together now I think

Piggieback was recently "given" to the Clojure-emacs org on GitHub and should receive more love. Agree with everything you say in the backlog here..it is still a heavy weight, hackinsh thing that quickly solved a tooling problem. That is why socket REPL has to happen.

Looks like lots of emacs folks are moving away from nrepl though

unrepl and spiral and inf-clojure

Yeah that is what I hope 😄 socket repl support is already a thing in inf-clojure and spiral/unrepl

And actually lumo and Planck are directly supported as well thanks to their socket servers

(in inf-clojure)

So does anyone have opinions on what method to use to switch between web connected repl clients?

I've been playing with :, :, etc.

The original design spec for socket repl mentions this: :repl/attach {:server server-name :client session-id} - attach to existing session and interpret vars in terms of that session

Which never got implemented

The place to hook into the reader though feeds through tokens though, not lines. I guess you could go popping and pushing values but it's easier just to use one value to represent your repl change request

and repl quitting is already :repl/quit

or you could make passing in a map optional, and if it has a particular key, it'll be read as a repl read time command

like {:cljs.repl/cmd :switch-client :value 3} or something

fighweel adds {:conn 2} to a prompt when a second connection is made.

I don't think client switching has been implemented yet

we definitely need to put together a contributing to Closure Compiler guide

it’s not hard, but Closure Compiler README itself doesn’t offer enough information

https://github.com/google/closure-compiler/issues/2846 now has a test case, hopefully this can make it into the May release

New page documenting how to contribute to Closure Compiler https://clojurescript.org/community/closure

Looks good! Here's a minor typo fix https://github.com/clojure/clojurescript-site/pull/204

Kicking off 1.10.238

Cool. Is this a release candidate? (Is it worth updating docs to point to that number?)

nah, this is just the release

OK. Will update any references in docs I've been maintaining.

Yes, I think we should push everything now, and then we can do announce on the mailing list tomorrow, social etc.

this includes site stuff

everything but the announce posts

OK, I'll leave dates as tomorrow.

great

@mfikes I don’t think the date bit is important for anything but the announce posts

I’m going to merge this stuff https://github.com/clojure/clojurescript-site/pull/173

Right. I think that's where dates are.

There are a lot of compiler option PRs that may conflict that we can merge early and resolve conflicts on.

yeah

Here is the gist listing all docs https://gist.github.com/mfikes/bdbe214f03abac88ae384adb1ac26490

release is building

Ahh cool regarding the news label. I realized after the fact that we may have been able to use a label instead of the gist above to achieve the same.

how do you guys want documentation typo reports / PRs?

For small typos, you can just use the ability to edit directly and submit a PR. https://clojurescript.org/community/contributing_site#minor

(For a typo in merged content.)

@mfikes yeah I think we only have three news posts

I merged the new Quick Start

@mfikes I think 156 & 178 are good for tomorrow

@mfikes my edit button on github, when editing directly, is grayed out and says "you must be signed in and have push access to master branch to make changes" which is weird if it's just a PR right?

and then I think 185 should wait till Wednesday while those first two soak in

OK, I can set 185's date for Wednesday

creating the uberjar, hopefully this is the last release we have to do that

@mfikes Sorry, I was looking at the source view directly. It does let me edit from the reading view

@mfikes so I’ll merge those two posts in the am tomorrow

OK

One minor issue to resolve is that the main new article for 1.10.238 has a link to the Shared AOT Cache news article, which would come out later. One way to resolve this would be to simply eliminate the small paragraph that says "You can read more at Shared AOT Cache."

If we do that, perhaps I can add a tiny bit more to that copy, to point to the :aot-cache compiler option or somesuch

I would change that to say that more information about that will be coming later

and link to the docs

OK

I guess, it would link to the news section as a whole. Let me see...

Like a link to https://clojurescript.org/news

Here is the revised paragraph in question: https://github.com/mfikes/clojurescript-site/blob/master/content/news/2018-03-26-release.adoc#shared-aot-cache

seems fine

if we want to edit that to point to post later - easy enough

Definitely. In hindsight, this time around instead of a "Sneak Preview" pre-release series of news posts, we are doing a post-release series. 🙂

after this release, I think we should just shoot for monthly releases a la Closure - I didn’t expect this one to take so long, almost six months?

Right, that can be good and bad.

There may be lots of bugs people have been waiting for for too long.

still this is an impressive release - a huge thanks to everyone that contributed and tested

@r0man btw I think I know why noone can reproduce your problem and I didn’t really believe the bug report since the situation seemed impossible wrt. code

the build will use whatever is in resources/brepl_client.js, we should clean that - and I think you have a bad one in there

we build a cached one

There's still a tiny PR pending to fix a list item and add mention for the :package-json-resolution flag: https://github.com/clojure/clojurescript/pull/71

^ Jannis you probably want to make a patch instead

And attach it to a JIRA

Yeah I never look at PRs on ClojureScript

Can do, just thought I'd reduce the hassle with a tiny improvement like that. I can get a patch ready tomorrow morning.

@dnolen No problem

We don’t take PRs at the moment, that might not have been clear

It's good to know though ;)

I have no experience with it, but there is a pull request template feature that could be abused to essentially include copy to redirect requestors to instead ensure CA signed and submit a JIRA patch. https://help.github.com/articles/creating-a-pull-request-template-for-your-repository/

I have a PR template for clojure-site

https://github.com/clojure/clojure-site/blob/master/.github/PULL_REQUEST_TEMPLATE

feel free to steal

@dnolen Thanks for taking a look at the node repl / piggieback issue. I kinda assume it was going to be something that should be changed in piggieback, though I appreciate you implementing that piggiehack. 😄 It works like a charm. Thanks, @mfikes, for testing as well. Sorry I wasn't around to test.

@john You mentioned spiral/inf-clojure; do you have experience moving from cider to one of those? Can you speak to the quality and usability of either one?

@ghopper think this is best asked in #unrepl which spiral is an implementation of (@volrath is the author of spiral and is in there as well). I think unrepl is very well designed, curious to know how it works for you if you give it a shot.

@mkvlr Thanks, I'll go there.

is 1.10.238 up on maven?

The last one took 12 hours to appear. It looks like we are only 9 hours into the process. 🙂