Clojurians
#cljs-dev
<
2018-02-22
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

mfikes15:02:00

@bronsa Another appealing argument: If the established bindings are only in effect in the scope of binding's body then some code can become more easy to reason about. An illustrative example: The call to current-alias-map here is currently affected by the env/*compiler* and ana/*cljs-ns* bindings being established a few lines earlier, even though those bindings are not really intended to be in effect until the body starts executing.

richiardiandrea18:02:40

The above happens with normal compilation tooling FWIW

dnolen18:02:15

@richiardiandrea -c is a main option, it must come last

richiardiandrea18:02:25

so there was a :reload-all in the ns declaration, taking it out solved

dnolen18:02:28

if you use -h you’ll see documentation about this

richiardiandrea18:02:39

cool yes I figured that out :wink:

richiardiandrea18:02:54

I will try to repro

mfikes19:02:53

^ I added a minimal repro that complies with https://clojurescript.org/community/reporting-issues

mfikes19:02:27

I wonder if it is a valid defect; it is not normal to put :reload-all in an ns form. Hrm.

richiardiandrea19:02:33

agree, I mainly use it at the repl...at least we should emit a warning or something

richiardiandrea20:02:05

today is either my unlucky day or I am doing very wrong things, this time I get a pg not found error with the following: https://github.com/arichiardi/cljs-pg-error/blob/master/scripts/cljs_build.clj#L27

mfikes20:02:06

So, another Java 9 (Nashorn) issue to add to the list: https://dev.clojure.org/jira/browse/CLJS-2542 (AFAIKT, all the unresolved Java 9 issues are related to Nashorn.)

dnolen21:02:50

@richiardiandrea yeah :reload-all is a REPL convenience (though technically I think this might work in Clojure)

dnolen21:02:55

I don’t really think we need to make this work

dnolen21:02:15

marking that ticket as minor for now

richiardiandrea21:02:21

kk cool, I am ok with that, it was still good reporting it

dnolen21:02:26

yes thanks

richiardiandrea21:02:09

I am about to open another one for the pg package, which compiles fine under lumo, but not under cljs vanilla unless I am doing something very wrong

richiardiandrea21:02:10

https://dev.clojure.org/jira/browse/CLJS-2544 btw sorry if it is not adhering to reporting, but I am isolating stuff as fast as I can from my actual project