Fork me on GitHub
#cljs-dev
<
2018-02-10
>
richiardiandrea00:02:58

So maybe this is silly again, but because cljs.core.specs.alpha is not required anywhere it seems like it is not compiled and then no included in things like main.out...is this expected?

dnolen12:02:07

@juhoteperi all your patches from above have been applied, thanks!

juhoteperi12:02:30

@dnolen Super! Great to have the Closure patch finally done after 4 months 🙂

rauh12:02:17

Just tested master on my project. All working! Great work! 😄

thheller14:02:38

@dnolen are you planning a new release soon? would be good to have the Java9 related changes out

mfikes14:02:56

(FWIW, this feature is not yet working for me, but documented it nonetheless. Here's the JIRA https://dev.clojure.org/jira/browse/CLJS-2497)

dnolen15:02:58

@thheller not very soon no

dnolen15:02:06

but not long, probably a couple of weeks?

thheller15:02:39

ah, I didn't see the earlier answer.

dnolen17:02:11

@mfikes thank we’ll want to tweak that - I just added our own entry point cljs.main, no more clojure.main

dnolen17:02:30

java -jar cljs.jar now starts Nashorn REPL

mfikes17:02:49

Ahh, nice simplification.

dnolen17:02:57

java -cp cljs.jar cljs.main -m ... instead of the Clojure stuff we don’t need

mfikes17:02:48

By the way, dunno if you noticed the ticket about this stuff failing for me.... (I've tried it on two separate boxes with the same result.)

mfikes18:02:06

Maybe it is the use of clojure.main?

dnolen18:02:26

yes, but haven’t had a chance to look at that closely

dnolen18:02:13

@mfikes I’m testing via script/uberjar and using that thing

dnolen18:02:31

and then try something simple like java -cp cljs.jar cljs.main -e "(+ 3 4)"

mfikes18:02:44

Yeah, me too (`script/uberjar`). I'll try revising it to use cljs.main instead to see if that works.

dnolen18:02:54

there’s a lot of polish work to do I think, but I just want to get all the basic functionality in first

dnolen19:02:08

huh, it’s a good thing we did the basics for files w/o namespaces support 🙂

juhoteperi23:02:18

I found the reason why JS modules didn't work after restarting compiler (cold recompile?): https://dev.clojure.org/jira/browse/CLJS-2500

juhoteperi23:02:57

Not sure if this became problem only after :js-namespaces was added in CLJS-2389, would have thought someone would have noticed this before if this has been happening for 5 months