Clojurians
#cljs-dev
<
2017-12-29
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen01:12:41

ok, good to know

favila18:12:06

@dnolen Any chance to get this merged? https://dev.clojure.org/jira/browse/CLJS-1965 (letfn is broken). We just ran into this and it caused a lot of head-scratching. It doesn't seem like "Minor" is the correct priority...

favila18:12:53

well nm, it needs tests

dpsutton21:12:03

@mfikes is it possible to use your coal-mine apparatus on a local clojurescript build with a patch applied?

dnolen21:12:56

@favila marked as minor as it’s top-level letfn not something I would necessarily consider idiomatic

dnolen21:12:24

but yes, need some tests for that patch, happy to take as a separate patch

dpsutton21:12:32

updated ticket with easier repro steps

dpsutton21:12:56

working on tests now

favila21:12:41

we should have tests for the expression context too

favila21:12:56

(those tests shouldn't fail today, if my thinking is right)

favila21:12:03

but it would catch any future regression

dpsutton22:12:21

+  (let [context (:context env)
+        wrap? (or (= :expr context) (= :statement context))]
this is checking for context against expression or statement. are there any other states that context could be?

dpsutton22:12:09

thanks very much

dpsutton22:12:43

failing tests patch submitted. thanks