Fork me on GitHub
#cljs-dev
<
2017-12-27
>
dnolen15:12:29

@mfikes good catch on reverse, I used your tweak

mfikes15:12:58

Cool @dnolen I also checked that my tweak doesn’t add a checked if

mfikes15:12:05

By the way, I’m working on a new regression testing thing that will help catch “language-level” regressions. It is partly how I ensured the correctness of the new iterate / cycle / repeat, and how I found the reverse bug: https://github.com/mfikes/coal-mine It is a work in progress (still adding more tests), and I’m working to hook it up to our nightly Canary test.

mfikes15:12:51

In short, it takes a crapton of working tests and drives them through the compiler, looking to see if anything regressed. (Currently at 40,000 assertions, and will probably grow to be several times more than that.)

mfikes16:12:56

ClojureScript master is currently at 1.9.999 💯

dnolen18:12:27

@mfikes nice on those tests!

mfikes18:12:13

Yeah. Even though compiler patches really need to be thoroughly understood, it doesn't hurt having lots and lots of tests to validate your thinking.