This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-12-23
Channels
- # adventofcode (92)
- # beginners (12)
- # boot (3)
- # boot-dev (38)
- # cider (9)
- # clara (26)
- # cljs-dev (26)
- # cljsrn (3)
- # clojars (3)
- # clojure (48)
- # clojure-france (6)
- # clojure-greece (2)
- # clojure-spec (3)
- # clojurescript (7)
- # datomic (3)
- # fulcro (6)
- # hoplon (19)
- # jobs-discuss (1)
- # leiningen (4)
- # lumo (9)
- # off-topic (8)
- # onyx (43)
- # planck (10)
- # powderkeg (4)
- # precept (44)
- # re-frame (4)
- # shadow-cljs (4)
- # sql (13)
- # uncomplicate (1)
- # unrepl (3)
@juhoteperi hrm https://github.com/clojure/clojurescript/commit/123e8f9aa59899c6886bbe392128b22ae9a0def3
how does this work with e.g. JSX pre-processing now?
if a file is .jsx
@anmonteiro Do we support jsx?
I thought we did, with :pre-process
I don't think so? If we will, that code would need to be updated
Ohhh.. yeah
Forgot about that
What would be the safest check here? Ignore only css? Allow js/json/jsx? Something else?
Closure might have some kind of TS support, or maybe that can be supported through preprocess also
perhaps introduce a compiler option for blacklisted extensions which defaults to only .css
?
That's good idea
so that people can override it too
if they have a :preprocess
for css
What about warning the first time a file is ignored?
doesn’t closure already do that?
I thought it did
Not in this case
@anmonteiro https://dev.clojure.org/jira/secure/attachment/17579/CLJS-2450.patch any comments? Is the option name OK?
I think so
looks OK to me
What about the warning? IF user has preprocess which does something with css, those would be now silently ignored
@juhoteperi I think logging that file is being ignored under :verbose
is fine?
I'll implement that in a moment
@juhoteperi +(some (fn [x] nil) [])
don’t think that needs to be in the patch https://dev.clojure.org/jira/secure/attachment/17581/CLJS-2450-2.patch