This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-12-08
Channels
- # adventofcode (240)
- # beginners (87)
- # boot (4)
- # cider (27)
- # cljs-dev (20)
- # cljsrn (24)
- # clojure (365)
- # clojure-argentina (1)
- # clojure-brasil (4)
- # clojure-dev (12)
- # clojure-greece (65)
- # clojure-india (1)
- # clojure-italy (15)
- # clojure-japan (1)
- # clojure-losangeles (1)
- # clojure-madison (4)
- # clojure-poland (3)
- # clojure-russia (5)
- # clojure-spec (3)
- # clojure-uk (105)
- # clojurescript (27)
- # core-async (1)
- # core-logic (3)
- # cursive (61)
- # datomic (68)
- # devcards (4)
- # docs (27)
- # duct (67)
- # emacs (15)
- # events (1)
- # fulcro (8)
- # graphql (50)
- # lein-figwheel (1)
- # lumo (15)
- # numerical-computing (1)
- # off-topic (77)
- # om (3)
- # onyx (5)
- # parinfer (3)
- # planck (2)
- # portkey (5)
- # re-frame (4)
- # reagent (16)
- # ring (14)
- # rum (3)
- # shadow-cljs (17)
- # vim (1)
I'm curious if ClojureScript' Spec implementation would be ultimately broken out from ClojureScript proper (and added to https://github.com/clojure/spec.alpha). (I also wonder if the plan is to ultimately have released versions of Spec that are independent of Clojure / ClojureScript.)
we’ve talked about it a few times and so far it has seemed easier to keep cljs spec in cljs rather than in spec.alpha
depending on what you mean in the parens, we are either already doing that or it doesn’t make sense :)
that is, spec is already a library independent of Clojure. it is released independently and while a particular version of Clojure depends on a particular version of spec, you are free to also override that with a newer version of spec
in cljs, obviously that dynamic is different due to its direct inclusion
but cljs releases much more frequently, so I don’t think it’s too critical
@alexmiller Cool. I was thinking that if the separation of spec.alpha
from Clojure was only a temporary thing to facilitate the 1.9.0
release, and if it were to be baked in, say 1.10.0
, then it would be silly to break spec.alpha
out of ClojureScript, given that long-term plan. Sounds like it will always be independent. ClojureScript could go either way on the subject.
atm I would say we don’t plan to re-integrate spec into Clojure
but I reserve the right to say something different later :)
yes I think given our different release cycle, keeping spec.alpha
in ClojureScript directly isn’t much of an issue
If you brew upgrade node
on macOS, bringing it to 9.2.1, then script/test-self-parity
only makes it through the first few tests and then abends on one of my computers. I'm going to figure out if this is a ClojureScript issue or a Node regression.
Node doesn't just die either, instead of
Ran 356 tests containing 18801 assertions.
0 failures, 0 errors.
I got fewer than the full suite being run, but with 0 failures, 0 errors.
It is not reproducible on the same box. Arg. Might be a race condition.Cool. It also works with v9.2.1 here on various boxes, but one was repeatedly exhibiting the "early termination". Will keep digging and trying to repro.
Here is an example of the self host tests failing under Node. No change other than repeating the test run several times until it occurs:
Testing with Node
Testing self-host.test
WARNING: double already refers to: cljs.core/double being replaced by: cljs.user/double at line 1
Ran 33 tests containing 206 assertions.
0 failures, 0 errors.
x
Full transcript of the run here: https://gist.github.com/mfikes/dc62cc12cb35a23fff5b576809caeafb^ Taking offline to deal with here: https://dev.clojure.org/jira/browse/CLJS-2438