Fork me on GitHub
#cljs-dev
<
2017-12-04
>
levitanong03:12:50

@mfikes does the env in cljs.analyzer/analyze contain the namespace?

levitanong04:12:17

nvm, figured it out. it does indeed contain the namespace.

juhoteperi10:12:34

I'm trying to get Reagent working on Node with foreign libs again, seems like https://github.com/clojure/clojurescript/commit/fc0989f1b44b97547410a2d2c807f16430b47486#diff-db201d3634488851510ee2fbce327924 broke the bootstrap script so that it only works with Node modules

juhoteperi10:12:06

the parts that affect this use case are global.require = require; and nodeGlobalRequire use in CLOSURE_IMPORT_SCRIPT, other parts don't matter

martinklepsch11:12:11

Is there a way to print compiler options as they are passed to the compiler? Could be useful for debugging / tooling authors

dnolen13:12:09

there isn’t but probably we should just do that under :verbose

dnolen13:12:09

@juhoteperi ok, that one caused way more trouble than it was worth for Node.js users

dnolen13:12:25

so whatever we come up with needs to not be problematic for the primary use case

juhoteperi13:12:44

Yeah, I think I found a solution which works for both cases

juhoteperi13:12:43

Reagent is now running tests with all different environments (node/browser, npm/foreign)

juhoteperi13:12:56

Antonio thought there might be already issue about this but we couldn't find one, here's a new one with a patch: https://dev.clojure.org/jira/browse/CLJS-2430

thheller20:12:38

this was just merged and probably affects CLJS interop https://github.com/google/closure-compiler/pull/2729

thheller20:12:44

from what I can gather module.exports = 1 not becomes module$something.default was module$something before

thheller20:12:57

exports.foo = 1 stays module$something.foo

thheller20:12:59

better matches ES6 default exports but I expect it is going to be weird for a whole bunch of npm packages