This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-11-30
Channels
- # beginners (126)
- # boot (2)
- # cider (6)
- # cljs-dev (46)
- # cljsjs (8)
- # clojure (122)
- # clojure-greece (57)
- # clojure-italy (6)
- # clojure-poland (3)
- # clojure-russia (2)
- # clojure-serbia (5)
- # clojure-spec (26)
- # clojure-uk (99)
- # clojurescript (39)
- # cursive (15)
- # datascript (7)
- # datomic (21)
- # dirac (7)
- # duct (1)
- # emacs (19)
- # fulcro (58)
- # garden (4)
- # graphql (15)
- # hoplon (2)
- # immutant (1)
- # instaparse (3)
- # jobs (5)
- # juxt (15)
- # klipse (4)
- # leiningen (2)
- # lumo (52)
- # off-topic (8)
- # om (27)
- # onyx (22)
- # other-languages (3)
- # portkey (2)
- # protorepl (2)
- # re-frame (7)
- # reagent (7)
- # ring (11)
- # rum (7)
- # shadow-cljs (114)
- # spacemacs (20)
- # specter (16)
- # test-check (5)
- # timbre (1)
- # unrepl (43)
- # yada (17)
David, if you end up doing tickets Friday, I'd vote for these two: https://dev.clojure.org/jira/browse/CLJS-2404 https://dev.clojure.org/jira/browse/CLJS-2377
It might be nice to have a formal way to indicate that the latest patch in JIRA no longer applies, so they can be filtered out from consideration, or specifically searched for. (Maybe a new label or some such.)
Part of me thinks this shouldn’t be an issue (that an informal comment would suffice). It just seems like there are a sizable number of JIRA tickets in that state.
It is about 30 of 107 patches that no longer apply. I suppose that is a significant portion.
I feel like it'd be really useful if into
worked with arrays. Clojure would probably have it if JVM arrays were dynamic in size.
Or another idea: (into-native dest xform coll)
that accepts both: js-objects and js arrays.
arrays worth considering if it’s cumbersome, but again I don’t remember this being a problem
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/@@iterator
@dnolen Yeah we can def. already handle js-arrays as the source, but not as the destination of into
. (into (array) xf coll)
is what I mean.
Yeah it's very easy. It could simplify code in core at a few places. Smaller code and probably faster code.
No proper xf
wont' work. I can do it easily with (transduce )
and a proper reducer, correct.
Could you expand on this? I am interested :) Isn't into
the same thing as a transducer in clj
? Does the current cljs
implementation varies from clj
in this regard?
@U0C8489U6 I can't do (into (array) xf xs)
since the array isn't a) EditableCollection b) Works with conj
. So I have to do a manual transduce
with a custom array reducer.
Of course you could hack it with (extent-type array ICollection (conj...))
but I don't like modifying that.
historically cljs has followed clj behavior, so I was trying to understand whether this breaks it
@rauh It looks like the same happens in clojure:
boot.user=> (into (make-array Integer/TYPE 100) (map inc) (range 10))
java.lang.ClassCastException: [I cannot be cast to clojure.lang.IPersistentCollection
So I’m looking for issues to work on, so I’m trying to use the issue filter, but neither “open” nor “unassigned” exactly imply an issue that isn’t being worked on. Is there some other indicator I could use to look for things that need work, but aren’t being worked on?
@levitanong See https://dev.clojure.org/display/community/Contributing, Issue tracking (JIRA) -> Tracking Tickets (for next release) -> ClojureScript -> Needs Patch link
Oh excellent! Thanks, @mfikes!
Nearly all of those aren’t being worked on. If you find a ticket of interest, it might be worth checking the Assignee field as an signal that it might be.
I’ll just add an additional filter to only look for unassigned 😄
Oh, except “This query is too complex to display in Simple mode.”
@levitanong An alternative is to click on the Assignee header twice to sort Unassigned ones to the top.
Thanks @mfikes!
Could you expand on this? I am interested :) Isn't into
the same thing as a transducer in clj
? Does the current cljs
implementation varies from clj
in this regard?
@rauh It looks like the same happens in clojure:
boot.user=> (into (make-array Integer/TYPE 100) (map inc) (range 10))
java.lang.ClassCastException: [I cannot be cast to clojure.lang.IPersistentCollection