This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-10-19
Channels
- # aws (4)
- # aws-lambda (2)
- # beginners (67)
- # boot (38)
- # cider (32)
- # cljs-dev (12)
- # cljsrn (2)
- # clojars (2)
- # clojure (190)
- # clojure-chicago (1)
- # clojure-dusseldorf (2)
- # clojure-germany (1)
- # clojure-greece (3)
- # clojure-italy (5)
- # clojure-russia (6)
- # clojure-spec (47)
- # clojure-uk (10)
- # clojurescript (59)
- # cursive (9)
- # data-science (14)
- # datomic (24)
- # devops (16)
- # emacs (8)
- # fulcro (25)
- # graphql (30)
- # hoplon (123)
- # juxt (15)
- # lambdaisland (2)
- # leiningen (4)
- # luminus (6)
- # lumo (9)
- # off-topic (11)
- # om (7)
- # onyx (8)
- # re-frame (14)
- # reagent (5)
- # ring-swagger (5)
- # shadow-cljs (46)
- # spacemacs (41)
- # specter (8)
- # testing (8)
- # unrepl (31)
- # yada (18)
@timgilbert Optimize step prints the errors here: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1369
And this doesn't affect exit code
Maybe optimize
(and optimize-modules
) should throw
at the end if there were errors
Ahh hmm, didn't check the problem correctly, optimize
is about errors during advanced build optimization step
ES6 goes through process-js-modules: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L2356 convert-js-modules: https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/closure.clj#L1681
@timgilbert I’m not sure this really something for us to address directly besides providing a hook for custom Closure error handlers
I think a hook would work fine for me (presumably lein-cljsbuild would then hook into that). What I'm trying to avoid is stuff getting auto-deployed from our CI system if a build doesn't compile, currently we can see the message in the CI logs, but cljsbuild
still returns 0 so it's hard to detect the failure.
I guess the idea would be that calling code could register a function to be called in (report-failure)
?
I think it should probably be a bit more general, i.e. a generic integration into Closure’s error reporting system. It should be pretty easy to do. And then the default reporter supplies a hook for build tools.
Hi, I have created an issue with proposal and a question for my first ClojureScipt patch, maybe someone with knowledge about how node.js specifics are implemented can give me feedback https://dev.clojure.org/jira/browse/CLJS-2386
@dnolen Yes I've seen it, thanks. I submitted my CA quite a while ago with another e-mail address than the one in the commit I think (a private one).
I think a hook would work fine for me (presumably lein-cljsbuild would then hook into that). What I'm trying to avoid is stuff getting auto-deployed from our CI system if a build doesn't compile, currently we can see the message in the CI logs, but cljsbuild
still returns 0 so it's hard to detect the failure.
I guess the idea would be that calling code could register a function to be called in (report-failure)
?