Clojurians
#cljs-dev
<
2017-10-19
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

juhoteperi07:10:44

And this doesn't affect exit code

juhoteperi07:10:31

Maybe optimize (and optimize-modules) should throw at the end if there were errors

juhoteperi08:10:34

Ahh hmm, didn't check the problem correctly, optimize is about errors during advanced build optimization step

dnolen12:10:28

@timgilbert I’m not sure this really something for us to address directly besides providing a hook for custom Closure error handlers

abp13:10:30

Hi, I have created an issue with proposal and a question for my first ClojureScipt patch, maybe someone with knowledge about how node.js specifics are implemented can give me feedback https://dev.clojure.org/jira/browse/CLJS-2386

dnolen18:10:25

@abp I left some feedback on the ticket, have you submitted your Clojure CA?

abp19:10:37

@dnolen Yes I've seen it, thanks. I submitted my CA quite a while ago with another e-mail address than the one in the commit I think (a private one).

timgilbert22:10:02

I think a hook would work fine for me (presumably lein-cljsbuild would then hook into that). What I'm trying to avoid is stuff getting auto-deployed from our CI system if a build doesn't compile, currently we can see the message in the CI logs, but cljsbuild still returns 0 so it's hard to detect the failure. I guess the idea would be that calling code could register a function to be called in (report-failure)?