Clojurians
#cljs-dev
<
2017-10-17
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

lxsameer10:10:40

@anmonteiro I just watched your recent talk in clojureConj, Kudos. It was awesome

lxsameer10:10:55

Regarding to NPM dependencies. I guess we can't do dead code elimination on those right ?

dnolen10:10:55

DCE is applied to everything that goes through Closure Compiler

dnolen10:10:01

doesn’t matter where it comes from

lxsameer10:10:08

In my understanding the code goes to closure compiler should have one of popular module types like commonjs and stuff like that in order for closure to do DCE on that, right ?

dnolen10:10:25

none of that stuff matters

dnolen10:10:40

if goes through Closure DCE will applied

thheller10:10:16

that does not mean that it will work after though. :wink:

lxsameer10:10:54

:)) yeah i know, It's tricky

lxsameer10:10:01

but still it's really cool

anmonteiro15:10:39

@lxsameer I actually made that clear in the last question people asked. Not sure if it ended up in the recording

lxsameer15:10:15

Nice, I skipped the QA

juhoteperi16:10:48

Hm, no October Closure-compiler release yet, I wonder if they are waiting on https://github.com/google/closure-compiler/pull/2641

juhoteperi16:10:04

Chad also has fix for using CJS modules from ES6 modules which depends on that PR

juhoteperi16:10:28

UMD wrapper fixes in master + these should really help with being able to consume more Node packages

thheller17:10:41

doing some work on the externs inference code

thheller17:10:44

(defn thing [{:keys [foo] :as this}]
  (.componentDidUpdate ^js/Thing this))

thheller17:10:06

seems like destructured bindings can’t be annotated

thheller17:10:50

not confident about that yet, barely understanding the code. maybe someone else can confirm.

anmonteiro17:10:26

@juhoteperi I think they said that commit is getting rolled back

juhoteperi17:10:29

Yeah, they rolled it back and are now working on a fix

thheller19:10:31

https://dev.clojure.org/jira/browse/CLJS-2385 could use a second opinion here, patch done.