Clojurians
#cljs-dev
<
2017-09-11
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

lxsameer11:09:38

what is the uri? specification ? should it be the same as what we have on clojure ( to check whether the given arg is an instance of goog.Uri ) ? or should it check the arg for a valid uri ?

dnolen11:09:15

@lxsameer does goog.Uri not check?

dnolen11:09:37

we shouldn’t do anything more than goog.Uri

lxsameer11:09:13

so basically pass the arg to goog.Uri right ? in this case it's not going to be a predicate any more

dnolen11:09:30

uri? should check do instance check

dnolen11:09:04

sorry for the confusion, I thought you were talking a bit more generally

lxsameer11:09:28

thanks. I guess it would be my entry to cljs dev :))

lxsameer12:09:30

is there any coding style standard for the source code ?

dnolen12:09:56

not really, 2 space indent is preferred over aggressive arguments alignment

dnolen12:09:58

but that’s about it

dnolen12:09:20

if there are stylistic issues someone will let you know when they review the patch

dnolen12:09:46

but we generally avoid gratuitous code golfing on issues

lxsameer12:09:14

also should I follow an specific docstring style ? I saw https://cljs.github.io/api/

dnolen12:09:36

I would just eyeball what we do in core and copy that

kommen13:09:41

I also wasn’t able to reproduce this with a reduced test case

kommen13:09:10

and hadn’t had time to look into this more yet. I was wondering if this var COMPILED; output is new since the latest clojurescript version

kommen13:09:23

as blickly noted in the closure issue, the closure compiler hasn’t really changed in that area

lxsameer13:09:27

how changes log works ? should i update it with the patch ?

dnolen13:09:45

changes log gets updated by me when we cut releases

lxsameer13:09:27

I sorta know the answer but just to make sure, cljs API should match clojure itself, right? e.g clojure.core/uri? should be in the same place just like clojure

dnolen13:09:41

what do you mean “same place”?

lxsameer13:09:56

under the same namespace

dnolen13:09:23

I’m assuming you meant cljs.core then?

juhoteperi13:09:11

Someone mentioned on Github issues that latest snapshot fixes this

juhoteperi13:09:16

Haven't yet had time to test myself

kommen13:09:41

maybe I can try it later

lxsameer15:09:35

how can i run just one test case of cljs ? it seems that lein test :only does not work

dnolen15:09:45

@lxsameer I usually fire up a REPL for that

dnolen15:09:04

but my impression was that Lein should do what you want too

lxsameer15:09:46

I'll use REPL, but i thought the same about lein, but apparently i doesn't pick the correct test

anmonteiro15:09:24

@lxsameer lein test :only works for me, I use it all the time

anmonteiro15:09:02

But only the compiler infrastructure tests are run with lein, it would seem to me that you're looking to run the runtime tests

lxsameer15:09:34

@anmonteiro that's a good point , thanks man

lxsameer16:09:53

It would be awesome to have some docs around this

slipset16:09:43

@lxsameer make notes of this as you go along, then write a blogpost or get it published on http://clojurescript.org.

slipset16:09:38

I think we’re quite a few who’d appreciate it, and even lend you a hand wrt proofreading or even writing.

lxsameer17:09:00

I'll do that for sure

dnolen19:09:08

@lxsameer or submit a PR for this page https://clojurescript.org/community/patches

lxsameer19:09:30

@dnolen sure , at first I'll try do write down the process for rookie contributor from the start until the code merge

lxsameer19:09:14

is there any nrepl REPL around in the source code ?

dnolen19:09:34

no just plain REPL setups

lxsameer19:09:55

@dnolen is it ok if I add one ?

dnolen19:09:08

undesirable

lxsameer19:09:29

may i know the reason ? :slightly_smiling_face:

dnolen20:09:27

@lxsameer it just encourages people to test stuff with nREPL which historically has been it’s own source of problems

dnolen20:09:36

gotta run bbiab

lxsameer20:09:55

ow, good to know, thanks

lxsameer22:09:00

@anmonteiro so it's about creating an api doc from cljs source and push it to github pages right ?

anmonteiro22:09:08

but it’s not that easy as you’ll see when you play with it :stuck_out_tongue:

lxsameer22:09:23

yeah I can imagine what would be the problem

anmonteiro22:09:35

because it’s dependent on the autodoc library which AFAIK doesn’t support CLJS

anmonteiro22:09:39

or it didn’t last time I looked

lxsameer22:09:52

it doesn't still

lxsameer22:09:24

are we tied to autodoc ?

lxsameer22:09:50

I mean can't we use other libs?

lxsameer22:09:10

@anmonteiro for example something like codox

anmonteiro23:09:10

Autodoc is what generates Clojure’s documentation

anmonteiro23:09:24

so I think we wanna use that one

anmonteiro23:09:32

david would know more

lxsameer23:09:43

cool, thanks man

lxsameer23:09:51

I'll ask him

dnolen23:09:06

for official docs, yes probably would want to use autodoc