hey guys, regarding to https://dev.clojure.org/jira/browse/CLJS-2166

what is the uri? specification ? should it be the same as what we have on clojure ( to check whether the given arg is an instance of goog.Uri ) ? or should it check the arg for a valid uri ?

@lxsameer does goog.Uri not check?

no

we shouldn’t do anything more than goog.Uri

so basically pass the arg to goog.Uri right ? in this case it's not going to be a predicate any more

no

uri? should check do instance check

ah ok

got it

sorry for the confusion, I thought you were talking a bit more generally

thanks. I guess it would be my entry to cljs dev :))

nice!

is there any coding style standard for the source code ?

not really, 2 space indent is preferred over aggressive arguments alignment

but that’s about it

ok thanks

if there are stylistic issues someone will let you know when they review the patch

but we generally avoid gratuitous code golfing on issues

also should I follow an specific docstring style ? I saw https://cljs.github.io/api/

I would just eyeball what we do in core and copy that

thanks

how changes log works ? should i update it with the patch ?

no

changes log gets updated by me when we cut releases

cool.

I sorta know the answer but just to make sure, cljs API should match clojure itself, right? e.g clojure.core/uri? should be in the same place just like clojure

what do you mean “same place”?

under the same namespace

I’m assuming you meant cljs.core then?

yeah

yes

thanks

how can i run just one test case of cljs ? it seems that lein test :only does not work

@lxsameer I usually fire up a REPL for that

but my impression was that Lein should do what you want too

I'll use REPL, but i thought the same about lein, but apparently i doesn't pick the correct test

@lxsameer lein test :only works for me, I use it all the time

But only the compiler infrastructure tests are run with lein, it would seem to me that you're looking to run the runtime tests

@anmonteiro that's a good point , thanks man

It would be awesome to have some docs around this

@lxsameer make notes of this as you go along, then write a blogpost or get it published on http://clojurescript.org.

I think we’re quite a few who’d appreciate it, and even lend you a hand wrt proofreading or even writing.

I'll do that for sure

@lxsameer or submit a PR for this page https://clojurescript.org/community/patches

@dnolen sure , at first I'll try do write down the process for rookie contributor from the start until the code merge

is there any nrepl REPL around in the source code ?

no just plain REPL setups

@dnolen is it ok if I add one ?

undesirable

may i know the reason ? 🙂

@lxsameer it just encourages people to test stuff with nREPL which historically has been it’s own source of problems

gotta run bbiab

ow, good to know, thanks

is this tick still valid ? https://dev.clojure.org/jira/browse/CLJS-1446

yeah

@anmonteiro so it's about creating an api doc from cljs source and push it to github pages right ?

yes, kinda

but it’s not that easy as you’ll see when you play with it 😛

yeah I can imagine what would be the problem

because it’s dependent on the autodoc library which AFAIK doesn’t support CLJS

or it didn’t last time I looked

it doesn't still

are we tied to autodoc ?

I mean can't we use other libs?

@anmonteiro for example something like codox

Autodoc is what generates Clojure’s documentation

so I think we wanna use that one

david would know more

cool, thanks man

I'll ask him

for official docs, yes probably would want to use autodoc