Clojurians
#cljs-dev
<
2017-08-15
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

dnolen00:08:58

so unless I hear some reason not to, will cut a release tomorrow

mfikes00:08:44

Sounds good with me

anmonteiro00:08:52

sounds good to me too

mfikes00:08:15

I'll kick off a Canary build. Don't expect to learn anything different but'll do so anyway

anmonteiro00:08:07

@dnolen I was thinking, given that we forked module-deps, we could just add the other dependencies as transitive to that module and require less NPM dependencies for users doing things manually

anmonteiro00:08:12

do you think this is a good idea?

anmonteiro00:08:07

we currently require @cljs-oss/module-deps, enhanced-resolve and konan

anmonteiro00:08:37

adding enhanced-resolve and konan to the dependencies of @cljs-oss/module-deps would allow us to only need that one

dnolen01:08:02

@anmonteiro seems like a fine idea to me

anmonteiro01:08:45

(I cut a release of @cljs-oss/module-deps in NPM as part of this ticket)

dnolen15:08:24

@bronsa ping here

dnolen15:08:52

oh scratch that one second

dnolen15:08:13

yeah not a problem during reading

juhoteperi20:08:10

@honzabrecka just mentioned a tool built on top of https://github.com/angular/tsickle on another channel, I tested using tsickle on leaflet defs from DefinitelyTyped, and the result looks very good: https://github.com/cljsjs/packages/compare/ts-d-externs?expand=1

juhoteperi20:08:00

Not sure yet what would be the most useful way to use these, but I could for example convert all 2500 defs to externs and package them for as cljsjs.extern/package-name "version" for easy use

juhoteperi20:08:23

Then the foreign-lib packages could depend on the latest extern package, but it would also be easy to use externs without foreign libs

honzabrecka20:08:52

That’s exactly my idea :slightly_smiling_face:

juhoteperi20:08:53

* DefinitelyTyped in fact has 3500 definitions

juhoteperi20:08:50

out of 420 cljsjs packages, 160 have type definitions on DefinitelyTyped, and some others are named differently

anmonteiro20:08:03

@juhoteperi there are also some other things in flowtyped

juhoteperi20:08:16

Some of the packages also probably maintain defs themselves

dnolen20:08:48

seems like an interesting idea

anmonteiro20:08:16

that converts Flow typedefs to Ocaml interface files

anmonteiro20:08:41

@dnolen would be cool if CLJS-2322 also made it to this release

dnolen20:08:45

@anmonteiro testing it now

juhoteperi20:08:21

CLJS-2294 would fix minor issues with compiler-options validation

anmonteiro20:08:25

@dnolen hrm should requires be munged with the core munge or cljs.compiler/munge?

anmonteiro20:08:51

I guess this is where a test case would be helpful

anmonteiro20:08:49

because we definitely use cljs.compiler/munge when we do goog.require

dnolen20:08:39

good catch, switched them all

dnolen20:08:02

no change to test results - but we’re not looking for discrepancies here

anmonteiro20:08:41

was Tony’s problem the fact that some of his namespaces had - in them?

anmonteiro20:08:48

and we were looking for underscores?

dnolen20:08:18

we index inputs and we need to canonicalize everything up front so lookups work consistently

dnolen20:08:43

we weren’t converting :requires so some looks up would fail

dnolen20:08:57

munge and comp/munge didn’t appear to make any difference in this case

dnolen20:08:29

ok I think this is it for now

dnolen20:08:35

would be good time to test master

anmonteiro20:08:47

@mfikes can you trigger a canary run?

dnolen20:08:11

will be back on an hour so to cut a release

mfikes20:08:05

Yep. I’ll do one now. In case you ever want to do one yourself, it is easy: Check out the jobs branch, and commit an empty commit that has the commit message “job”:

git commit --allow-empty -m "job"

darwin20:08:27

@anmonteiro you can also specify some extra params, like --compiler-repo or --compiler-rev to point to your own fork or specify exact revision, see the readme here: https://github.com/cljs-oss/canary/tree/jobs

darwin20:08:01

btw. would be great to add lumo as a canary task when you get a minute, I will assist you

darwin20:08:15

I see that you already use travis, so it should be quite easy

honzabrecka21:08:28

@juhoteperi I’m converting all defs from DefinitelyTyped, here’s first bunch https://github.com/honzabrecka/ts-to-goog/tree/definitelytyped/externs

honzabrecka21:08:51

It’s based on https://github.com/Microsoft/types-publisher - I plan to use it to keep externs in sync.

dnolen22:08:04

bumped this one back up because @tony.kay encountered it

dnolen22:08:03

hopefully will fix, but it may affect other things - it’s hard to say - if you have a larger project esp. with a lot of :preloads tooling, try master

dnolen22:08:27

release definitely going to be delayed until this sorted out - hopefully tomorrow

anmonteiro23:08:13

@dnolen this was probably seen as far back as https://dev.clojure.org/jira/browse/CLJS-1821

anmonteiro23:08:22

probably seeing this again now because we’re always injecting the process shim preload

anmonteiro23:08:28

@dnolen if this is indeed the fix, I think we should only sort deps again if we do really have preloads otherwise it’s a useless sort

dnolen23:08:25

Notes and agree

dnolen23:08:57

Noted I mean

anmonteiro23:08:40

If only I could have a reliable repro

anmonteiro23:08:45

@tony.kay do you have one?

tony.kay23:08:16

well, it doesn’t fail with 905

tony.kay23:08:14

@anmonteiro Do you want a github commit and instructions? I can test your change if you want.

anmonteiro23:08:35

no, I want a reliable repro to include as a test in the CLJS codebase

tony.kay23:08:53

oh, my repro is on a large project…it isn’t something to put in a codebase :slightly_smiling_face:

tony.kay23:08:30

However, if you figure out a case, I can verify any change doesn’t break my project, which is nice to know :wink: