This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # aws (1)
- # beginners (52)
- # boot (1)
- # cider (9)
- # clara (4)
- # cljs-dev (40)
- # cljsrn (2)
- # clojure (168)
- # clojure-dusseldorf (1)
- # clojure-italy (34)
- # clojure-spec (13)
- # clojure-uk (35)
- # clojurescript (337)
- # cursive (11)
- # data-science (47)
- # datomic (11)
- # emacs (3)
- # events (1)
- # fulcro (58)
- # hoplon (16)
- # jobs-discuss (1)
- # juxt (11)
- # keechma (21)
- # mount (2)
- # off-topic (42)
- # onyx (9)
- # re-frame (33)
- # reagent (1)
- # ring-swagger (3)
- # spacemacs (1)
- # specter (2)
- # test-check (37)
@anmonteiro I created a repo that reproduces the issue: https://github.com/symfrog/cljs-modules-react-order . I think the cause is related to the necessary dependency exclusion here https://github.com/symfrog/cljs-modules-react-order/blob/master/project.clj#L5 . Running
lein deps :tree shows the following dependencies:
[cljsjs/react-dom "15.5.4-0" :exclusions [[cljsjs/react]]]
cljsjs.react in its deps.cljs and
cljsjs.react in its deps.cljs.
I ran into more emoji-related bugs with self-hosted compiler, and subsequently found bugs in my previous fix for https://dev.clojure.org/jira/browse/CLJS-1576. Just uploaded a new patch.
> React-with-addons bundle [has been deprecated](https://facebook.github.io/react/docs/addons.html) and Cljsjs no longer provides new versions
> of that package. The latest React-with-addons version won't work with Reagent 0.8.
> For animation utils use [react-transition-group](https://github.com/cljsjs/packages/tree/master/react-transition-group) package instead (TODO: Update to use
> (https://facebook.github.io/react/docs/test-utils.html) and [react-addons-perf](https://facebook.github.io/react/docs/perf.html) are not currently packaged as browserified files, so their use would require Webpack, or they might work with Closure module processing (TODO: Provide example).
@juhoteperi Thanks, I have already switched and I am not using react-with-addons, just using it to illustrate the potential bug
@dnolen The deps.cljs seem to be correct in both
cljsjs/react-dom, both are cljsjs packages and are the only dependencies specified other than clj/cljs. I will try to produce something more minimal.
@anmonteiro FWIW, CLJS-2318 caused a failure for my CI (which I can’t repro locally): https://travis-ci.org/mfikes/clojurescript/builds/264352764#L1941-L1943
OK. That could likely explain it. I’ll have it do another build without cache to ensure it doesn’t repro again.
^ subsequent re-build succeeded, so this was likely indeed just a transient error owing to a botched download checksum
no reason for it to fail. It had passed multiple times before in both your CI and mine
@anmonteiro A clean clone of https://github.com/symfrog/cljs-modules-react-order followed by running
./scripts/release outputs React DOM before React in ./release/mobuleb.js on my side. I have not been able to reproduce this with more minimal cases, so it might be something specific to that repo or I might just not be spotting the cause to extract into a more minimal case.
@anmonteiro Thanks, I saw that and extracted that test into packaged library equivalents with deps.cljs, and could still not reproduce the issue
I also suspected that
cljs.closure/get-upstream-deps might be returning incorrect values for that specific case, but it returned the correct values