Looks like the browser field support I added in Closure might be going in today

nice!

I guess I’ll take this one as a compliment too: https://github.com/google/closure-compiler/pull/2604#pullrequestreview-54993997

@anmonteiro heh, cool

^ this just went in

@dnolen the Closure default is "browser", "module", "main"

I wonder if we should provide a CLJS option to override it

or just set a nice default

wow

I think it’s a reasonable default for us because we don’t process files with Closure anymore under :target :nodejs

it’s also what Webpack does

yeah

the "module" one is the one I’m concerned about

I think we can roll with it and see what feedback we get

this + @juhoteperi’s UMD patch should make for an even nicer experience overall

sounds good to me, I’ll definitely have some time this Friday to work on our own Closure artifact. Before that I’ll probably cut a release to address these latest :modules issues and the js-obj thing.

@dnolen would also be nice if you could cut a Closure Library release. I can take over putting together a patch that upgrades it

oh right, did we make a ticket for that? If not feel free to make one and assign it me.

I forgot 🙂

making one now

https://dev.clojure.org/jira/browse/CLJS-2311