Clojurians
#cljs-dev
<
2017-08-08
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro17:08:38

Looks like the browser field support I added in Closure might be going in today

dnolen17:08:42

@anmonteiro heh, cool

anmonteiro20:08:39

^ this just went in

anmonteiro20:08:01

@dnolen the Closure default is "browser", "module", "main"

anmonteiro20:08:16

I wonder if we should provide a CLJS option to override it

anmonteiro20:08:32

or just set a nice default

anmonteiro20:08:50

I think it’s a reasonable default for us because we don’t process files with Closure anymore under :target :nodejs

anmonteiro20:08:04

it’s also what Webpack does

anmonteiro20:08:20

the "module" one is the one I’m concerned about

anmonteiro20:08:58

I think we can roll with it and see what feedback we get

anmonteiro20:08:45

this + @juhoteperi’s UMD patch should make for an even nicer experience overall

dnolen20:08:50

sounds good to me, I’ll definitely have some time this Friday to work on our own Closure artifact. Before that I’ll probably cut a release to address these latest :modules issues and the js-obj thing.

anmonteiro20:08:59

@dnolen would also be nice if you could cut a Closure Library release. I can take over putting together a patch that upgrades it

dnolen20:08:56

oh right, did we make a ticket for that? If not feel free to make one and assign it me.

anmonteiro20:08:08

I forgot :slightly_smiling_face:

anmonteiro20:08:14

making one now