Fork me on GitHub
#cljs-dev
<
2017-08-07
>
Oliver George03:08:36

@anmonteiro looks like 2291 commit resolved the build issues we were seeing on Windows. Thanks.

anmonteiro03:08:21

lein test now has 0 failures on Windows with that one ^

anmonteiro16:08:28

I think we should also consider upgrading the Closure Library

anmonteiro16:08:45

but they did some more breaking changes as usual

anmonteiro16:08:53

like removing some namespaces and functions

dnolen16:08:10

@anmonteiro issue welcome, would be nice to get what you鈥檝e observed will break in there

dnolen16:08:16

thanks for the rebased patch

anmonteiro16:08:40

@dnolen I鈥檝e preemptively reported something to boot-reload already: https://github.com/adzerk-oss/boot-reload/issues/117

anmonteiro16:08:12

the 2 other things I鈥檝e noticed so far are 1. some HybridJSON namespace that was deleted and breaks self-parity tests 2. they changed goog/boostrap/nodejs.js so we鈥檒l need to add a function and change another

mfikes19:08:51

Hah! Congrats @anmonteiro. Noticed you have 200 commits now!

anmonteiro19:08:14

woohooo 馃帀