Fork me on GitHub
#cljs-dev
<
2017-07-29
>
rauh12:07:40

Just trying out the new release. I'm using js-obj in my code and it's obviously complaining about gobject being undeclared. Should this be FQN'd?

dnolen13:07:34

@rauh need to see something minimal, js-obj didn’t change far as I know

rauh13:07:34

@dnolen It's this commit & line:

rauh13:07:09

Minimal, in any cljs namespace (not core) use (js-obj :a :b)

rauh13:07:10

Oh I see somebody was faster 🙂

mfikes13:07:38

(You can work around by requiring [goog.object :as gobject] in your ns)

rauh13:07:08

Yeah I worked around it. No biggie

dnolen13:07:45

thanks, will cut a release not later than Monday for this

mfikes13:07:37

One saving grace about the js-obj regression is that it only appears to affect code passing non-string keys.

dnolen13:07:25

yeah I also think #js is probably more popular these days too

rauh13:07:25

Was something changed about how functions are printed? I now only get a #object[retxyz]

dnolen13:07:46

yes, *print-fn-bodies* was added and it’s now false by default

mfikes13:07:19

(I think I'll write a short blog post about that one, to help promote knowledge.)

dnolen13:07:48

yes, to be honest I’m amazed we kept the old behavior around for so long - so annoying for debugging 🙂

mfikes13:07:22

Hah, I finally started reading "The Good Parts". Until recently, it has been a foreign language, I didn't like seeing. 🙂

juhoteperi20:07:59

I have updated Cljsjs React packages to include foreign-libs with same name as npm packages and with :global-exports: https://github.com/cljsjs/packages/pull/1275

anmonteiro21:07:29

looking into the es6 module resolution

anmonteiro21:07:36

not sure module-deps can figure out imports

anmonteiro21:07:05

I’ll play around with it a little bit more