This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-07-16
Channels
- # aleph (4)
- # bangalore-clj (10)
- # beginners (39)
- # boot (24)
- # cljs-dev (66)
- # cljsrn (79)
- # clojure (39)
- # clojure-italy (7)
- # clojure-russia (6)
- # clojure-spec (4)
- # clojure-uk (1)
- # clojurescript (91)
- # core-async (1)
- # core-typed (2)
- # datomic (49)
- # hoplon (42)
- # lumo (2)
- # nyc (1)
- # off-topic (1)
- # parinfer (20)
- # pedestal (2)
- # reagent (4)
- # rum (14)
- # vim (2)
fixed, working on a test
working on an enhancement after encountering an annoyance with testing :global-exports
previously :foreign-lib
overrides had to be keyed on :file
but that鈥檚 a strange requirement
^ what does this change?
looks the same to me?
@anmonteiro it never worked before
right that never worked before
but how would it work now? 馃檪
rely on an upstream declaration and allow users to provide their global exports?
^ foreign lib regression fix
@anmonteiro it did work before 馃檪
but they had to provide a file, right?
and you鈥檙e making it possible not to
by keying on provides
@anmonteiro there鈥檚 no context on CLJS-2249
@dnolen it鈥檚 the same fix you did to make analyze-deps
happy for non-node targets
we need to add js-dependency-index
to the compiler env
or it won鈥檛 know about foreign libs
every other test we have works because it didn鈥檛 exercise requiring foreign-libs
if you comment the changes I did to cljs.closure
you鈥檒l see the tests failing with an error that it can鈥檛 find the foreign lib that the test requires
@anmonteiro hrm yeah I think this patch is strange?
you鈥檙e totally right
we should add js-dependency-index
to the compiler-env no matter what
but we鈥檙e not
so your fix probably supersedes this one
yeah, I鈥檒l close the ticket
@anmonteiro try your test against master
sadly hacking on ClojureScript and needing to run tests ain鈥檛 exactly good for battery life
yeah the test passes now
attaching a revised patch
re: battery life, I bet the JVM drains it pretty quickly 馃槥
I鈥檓 going to punt on this overrides enhancements for now, it鈥檚 a little more subtle to do correctly than I鈥檓 interested in considering - but will come back to it later
Fork the repo and push your changes to your fork and let Travis take the hit on amp-hours.
before my battery dies, cool to note that this is the most active period in ClojureScript development since the beginning, REPL overhaul, & bootstrapping https://github.com/clojure/clojurescript/graphs/contributors
exciting
@dnolen follow up fix to the JS dependency index thing https://dev.clojure.org/jira/browse/CLJS-2251
I don鈥檛 think we should force every caller of cljs.env/default-compiler-env
to pass in the full options (with implicit options added)
my patch addresses that by bringing back the call to updating the compiler env with the js-dependency-index at that point which fixes every upstream call of cljs.closure/build
, whatever the arity
pretty sure the way you handled it in current master is a breaking change to everybody that鈥檚 assembling their own compiler env
(added a new test case too that demonstrates the issue - another arity and 馃挜 )