This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-06-25
Channels
- # beginners (32)
- # boot (1)
- # cljs-dev (25)
- # cljsrn (1)
- # clojure (35)
- # clojure-dev (6)
- # clojure-nl (4)
- # clojure-russia (12)
- # clojure-spec (13)
- # clojure-switzerland (2)
- # clojurescript (63)
- # cursive (9)
- # datomic (18)
- # dirac (32)
- # graphql (6)
- # luminus (8)
- # off-topic (18)
- # pedestal (5)
- # protorepl (1)
- # re-frame (30)
- # remote-jobs (5)
- # untangled (61)
- # yada (7)
anybody else getting some duplicate warnings when running tests with current master?
(for undeclared variables)
other than the above, all tests pass in Lumo downstream
^ seems like a minor issue because it doesn’t affect non-`:static-fns` (when warnings are normally dealt with)
Also, when testing master, don't forget to try the new compiler switch :fn-invoke-direct
. It should "just work" without having to modify any code. Has anybody tried it yet?
Perhaps an :fn-invoke-direct
change could be queued up for https://clojurescript.org/reference/compiler-options
I wonder if :fn-invoke-direct
should be in build-affecting-options
(https://github.com/clojure/clojurescript/blob/7089c9d51ab8b1011560dc4b8ca7ad92c77e8fdc/src/main/clojure/cljs/compiler.cljc#L1211-L1212)
TL;DR adding it there would cause any cached code to be re-compiled in order to honor the option
I can’t get :fn-invoke-direct
to cause different code to be emitted.
I have :repl-verbose true :static-fns true :fn-invoke-direct true
in script/noderepljs
and, while the :static-fns
flag is working, :fn-invoke-direct
doesn’t seem to elide call
in the JavaScript emitted, for example (defn f [x] (x 1))