Fork me on GitHub
#cljs-dev
<
2017-06-24
>
dnolen00:06:18

change will be pretty boring, just do the same thing for registry-ref and store in :cljs.spec/registry-ref

mfikes00:06:04

Self hosts test are almost done. I think I need to buy a new computer.

mfikes00:06:13

Attached the wrong -v3 patch. 🙂 Fixing that now.

dnolen00:06:17

checking it out

dnolen00:06:21

ok added support for registry-ref but I don’t have enough time to test that rigorously

dnolen00:06:39

did at least confirm that speced-vars wasn’t affected for regular ClojureScript

dnolen00:06:45

will do some more rigorous testing tomorrow

dnolen00:06:54

anyone else welcome to kick the tires too

mfikes01:06:46

registry-ref LGTM downstream in Planck

mfikes12:06:48

There was a failure in self-host related to registry-ref. Digging into it via https://dev.clojure.org/jira/browse/CLJS-2124

mfikes12:06:02

I also found a regression I had introduced with CLJS-2117 (the port of the spec caching stuff to self host), and attached a fix to https://dev.clojure.org/jira/browse/CLJS-2122

mfikes13:06:04

Finished my initial round of testing / fixing for the spec caching stuff. Logged and added patches to CLJS-2121 through CLJS-2124 covering stuff found / fixed.

dnolen15:06:35

@mfikes thanks checking those out

mfikes15:06:19

Thanks! Will check things out

mfikes15:06:13

Mentioned eminent release on Twitter. Perhaps we could also mention it in #clojurescript if it is ready for tire-kicking.

rauh15:06:06

Q: How do I set a patch to "Code" vs "code & test"? I can't find it.

dnolen15:06:22

@rauh you need to edit the ticket

rauh15:06:21

Oh! There it is 🙂