This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
- # beginners (78)
- # boot (25)
- # cider (13)
- # cljs-dev (41)
- # cljsrn (4)
- # clojure (213)
- # clojure-android (1)
- # clojure-conj (6)
- # clojure-greece (1)
- # clojure-italy (11)
- # clojure-russia (127)
- # clojure-spec (55)
- # clojure-uk (34)
- # clojurescript (68)
- # core-async (5)
- # cursive (5)
- # data-science (1)
- # datomic (3)
- # dirac (11)
- # editors (7)
- # events (1)
- # graphql (5)
- # hoplon (36)
- # jobs (1)
- # liberator (3)
- # lumo (101)
- # off-topic (20)
- # om (4)
- # onyx (3)
- # parinfer (14)
- # re-frame (7)
- # reagent (2)
- # remote-jobs (1)
- # ring-swagger (17)
- # sql (21)
- # untangled (38)
- # yada (23)
Not sure if anyone has looked at Zach Tellman's https://github.com/ztellman/collection-check? Seems like that might be a good tester for the new hashing?
Feels like I'm close to being able to fix but I'm not familiar with the correct approach for normalising paths (e.g. windows \\ and linux /)
(System/getProperty "user.dir") returns
"C:\\Repos\\utas-webapps\\frontend\\" but I need
"/C:/Repos/utas-webapps/frontend/" in order to strip the prefix.
@favila I mentioned that all callers of equiv are IKVReduce in patch, but was probably did make that very clear. Yes the fallback is bad - that is indeed an undefined variable i introduced. Ouch! @theller the records no longer use equiv-map it uses a set of fields checks and then a regular = check on the extmap as of cljs-2079. Also, the call made to 'equiv-map' by PAMs are redundant, it is made in the else branch of the if statement: (if (map? other) (not (record? other)) .... (equiv-map coll other)) which is pointless as 'other' is known not be a map by this point so equiv-map will always return false.
I see my typos was fixed. Thanks @dnolen ! btw I can make a test case for the fallback case if it would be helpful.
I remember calling private functions used to be an error. Eg, I once had to hack around it like
(js/cljs.core.fn__GT_comparator ...). Did that change?
Hmm, I wonder where I got the error from. I could've sworn it didn't work using a normal
(fn->comparator ...) call. Oh well...
I'm still not clear on why the bug is exhibited specifically when using :preload which leads me to think there's something more to it. I'm struggling to find that and don't have time just now to get more familiar.
@olivergeorge your patch looks OK but you need to follow the patch guidelines here https://clojurescript.org/community/patches
PSA: If you are authoring patches, you can now also include generative tests (using
test.check). The first such test has landed, exercising the ability for this to properly span JVM and self-hosted.
should there be a separate test workflow for those? generative tests take much longer to run
defspec seems to argue that Clojure hasn’t yet started to worry about test run time. (They are mixed in and there aren’t very many yet.)
We are seeing 15-30% decrease in total script time after CLJS-2079 and CLJS-1977 from Chrome's performance tab.
I know we have a strange use case, but this is a big deal for us. Kudos all around.
the Clojure JVM build has both unit tests and generative tests (actually these are the old test.generative, not test.check) and it’s possible to run them independently or together. I usually run them both as the generative ones don’t actually take that long right now.
we also have test.check tests but they are currently mingled into the unit test segment (because reasons)
Hi All. Possibly silly question. What's the recommended approach to building the clojurescript compiler on Windows? I used a docker vm to avoid the issue but perhaps there's a less fiddly way.
I get errors running script/build using the Git bash install on windows.
Exception in thread "main" java.io.FileNotFoundException: Could not locate cljs/closure__init.class or cljs/closure.clj on classpath., compiling:(C:\repos\clojurescript\script\aot.clj:1:1)
In case it's of interest this was my docker work around
docker run -v c:\repos\clojurescript\:/app -w /app -it clojure
maybe you could try to run it in linux subsystem in windows (I have never tried that before)