Should MetaFn implement ICloneable?

@rauh I don’t see any good reason for that

@dnolen (specify some-meta-fn ...) fails without it. Not a common use case TBH, so I'd agree that it's not a good reason.

I don’t see any reason why specify should work on actual fns

@dnolen Could you elaborate on the MetaFn/DCE comment you just wrote? I'm confused.

need more information

adding protocol indirection is just degrading performance for saving how many bytes?

if it’s 1K in typical projects, this isn’t important

But where would we add protocol indirection? If we substitute with-meta for -with-meta?

I mean, the protocol gets called in with-meta anyways, so we save a function call, no?

oh right, brain lapse, sorry I was thinking those with-meta were method calls but they aren’t

@dnolen are you doing a new build/release today?

wasn’t planning on it, there’s nothing particular important that’s come through

I’d like to get my hands on a release with CLJS-2040

but no rush

@dnolen I’m just preparing a patch with the new changes to spec that landed today

not sure if it warrants “important” or not though 🙂

ok, could do for spec changes

btw I also upgraded Closure to the May release as part of https://dev.clojure.org/jira/browse/CLJS-2027

@dnolen I think we should also consider upgrading Closure Library again. Someone mentioned they needed something that had been released in a newer version a couple days ago

(not for this release)

yeah ok, I can trigger a build of Closure Library

@dnolen https://dev.clojure.org/jira/browse/CLJS-2052

would be nice to get some verification that this patch doesn’t affect source mapping https://dev.clojure.org/jira/browse/CLJS-2051?focusedCommentId=45737#comment-45737

would also love to have a release with https://dev.clojure.org/jira/browse/CLJS-2021 (I'm on the list this time)

@frank patch won’t apply, did you follow the patch creation instructions?

Patch format detection failed. is the message from git am

ahh oops didn't see those. I'll fix it now

submitted a proper patch this time

@frank thanks, applied

I just cut org.clojure/google-closure-library and org.clojure/google-closure-library-third-party version 0.0-20170519-fa0499ef, might want to take that for a spin

trying it now

@dnolen small typo above (messes with copy-pasting) org.closure->`org.clojure`

@anmonteiro thanks fixed

sorry, also google-closure-third-party -> google-closure-library-third-party

all tests pass downstream in Lumo, but we don’t use the Closure Library a great deal

@anmonteiro still that’s good to know

same thing in Om

unless someone has an objection I’m going to cut a release of ClojureScript now

@dnolen did you get to CLJS-2027?

oops didn’t

doing that now

@anmonteiro actually needs a rebase

am -3 wouldn’t work

doing it now

k thanks

@dnolen attached rebased patch https://dev.clojure.org/jira/browse/CLJS-2027

@anmonteiro didn’t work 🙂

there’s a lot of stuff in that patch from previous commit

oh I messed up

1 sec

@dnolen sorry about that, fixed now

also, please hold up on the release, @mfikes found a slight problem with self-host

Actually, it affects JVM as well: https://dev.clojure.org/jira/browse/CLJS-2053

patch attached

any->`any?`

bad copy paste from this commit https://github.com/clojure/spec.alpha/commit/607aef0643f6cf920293130d45e6160d93fda908

@anmonteiro got it

great

The patch fixed it for JVM, but in self-host, I got

WARNING: Use of undeclared Var cljs.spec.alpha/any? at line 34 src/planck/core.cljs

Odd. I wonder if it is meant to refer to the core any? predicate…

it is

Syntax quote is probably broken in self-host

right

I’ll file a separate self-host issue. This shouln’t block a JVM release.

I could also edit this ticket to read cljs.core/any?

@mfikes @anmonteiro let’s just fix this, just namespace that symbol right?

Yeah, was thinking that too. If you literally put in 'cljs.core/any? it might do it

@anmonteiro applied the ES7 thing

er 2017 or whatever it’s called 🙂

@mfikes which test are you running for self-host the self-parity one?

I’m here and can fix the issue now

I just noticed this downstream in Planck unfortunately

If you are thinking about fixing it, I can easily confirm

@mfikes done

Cool. Testing now.

@dnolen That change looks good. I'm on to other errors in Planck now, which I think are cut-n-dry things where I need to just update for the latest Google Closure namespaces.

k

I'll sort out a minimal repro for the fact that syntax-quote is somehow broken for this case in self-host, and file a JIRA, etc.

@dnolen I forgot a call to "with-meta" in core.cljc for https://dev.clojure.org/jira/browse/CLJS-1884, should I reopen the issue ?

@ewen just point it out to me now and I will fix it

it's here https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/core.cljc#L1786

thx @rauh for pointing it out

cool, changed here & testing now

cutting a release now

thx 🙂