This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-05-07
Channels
- # aleph (8)
- # beginners (16)
- # boot (5)
- # cider (22)
- # cljs-dev (15)
- # clojars (10)
- # clojure (94)
- # clojure-dusseldorf (1)
- # clojure-france (57)
- # clojure-greece (1)
- # clojure-spec (9)
- # clojurescript (15)
- # core-async (6)
- # cursive (11)
- # datomic (10)
- # emacs (6)
- # funcool (1)
- # hoplon (1)
- # off-topic (5)
- # re-frame (8)
- # spacemacs (8)
- # specter (4)
- # unrepl (10)
- # vim (5)
A couple of days ago, there was the suggestion that ^boolean js/goog.DEBUG
didn't work any more as a means to remove (DCE) dev-only code.
I undertook to check, which I have now done.
As a result:
https://dev.clojure.org/jira/browse/CLJS-2023
(Sigh. I wish i could edit my issue to clean up my silly spelling errors which, strangely, only become visible to me once I click Create. Moving on)
@mikethompson added a quick comment identifying the actual bad commit. don't have time for more currently.
@thheller Thanks! We're going through and changing all js/goog.DEBUG
to goog.DEBUG
... so we'll soon be free of the issue. But I'm sure others will get burned because it triggers DCE failures silently.
Just submitted https://dev.clojure.org/jira/browse/CLJ-2162 . I think that'd also be a candidate for cljs, since then the truthy calls can be avoided. A quick github search shows that (condp = ...)
is very common.
@mikethompson you need to ask Alex Miller for more JIRA permissions to edit your issues
@mikethompson I gave you edit rights in jira
@alexmiller Luxury! Thanks. Fixed.
@mikethompson I think “^boolean goog.DEBUG” should be “^boolean goog/DEBUG”
in https://dev.clojure.org/jira/browse/CLJS-2023 description
Oh, interesting. I've not seen that before.
Does that mean we should change these kinds of docs:
https://clojurescript.org/reference/compiler-options#closure-defines
It contains references to goog.DEBUG
I don’t understand it fully but there is some translation, “goog. x.y.z” false will be defined as goog.x.y.z=false
in js
Makes sense. @dnolen is darwin's suggestion here officially-the-right-thing-to-do?