Clojurians
#cljs-dev
<
2017-05-05
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

vikeri11:05:59

I have an interesting issue, when I get an circular dependency through a macro it won’t be detected when using :parallel-build true. If I disable parallel build it detects it. Tested with 1.9.521

vikeri11:05:15

What happens instead is that the process just freezes

dnolen17:05:51

@vikeri “Circular dependency through a macro” what does that mean?

dnolen17:05:30

Clojure nor ClojureScript support circular deps anyway

frank18:05:26

@vikeri how does one reproduce this?

anmonteiro18:05:53

@tmulvaney In Clojure,

(type (find {:a 1} :a))
clojure.lang.MapEntry

anmonteiro18:05:14

does your recent patch also return a MapEntry for find?

dnolen18:05:16

I just changed cljs.spec to cljs.spec.alpha now would be a good time to try master - would like to cut a release for this

anmonteiro19:05:02

@dnolen so you didn’t delete .spec namespaces? e.g. cljs.spec.impl.gen

anmonteiro19:05:21

or cljs.spec.test

anmonteiro19:05:42

we’ll have cljs.spec.test and cljs.spec.test.alpha?

dnolen19:05:58

no those should be gone

dnolen19:05:52

@anmonteiro oops your right fixed now

anmonteiro19:05:54

@dnolen another question is: you added cljs/spec/impl/gen because there was a cljs.spec/gen var.

anmonteiro19:05:02

should we change it back or keep impl?

anmonteiro19:05:23

I don’t think it’s a pressing issue, just thought I’d start the discussion

dnolen19:05:35

oh right, we can change that

dnolen19:05:31

changing it now thanks

dnolen19:05:59

changes applied to master

mfikes20:05:47

Guessing simply cljs.spec.alpha$macros/speced-vars

anmonteiro20:05:08

putting together a patch

mfikes21:05:17

With ^, the spec -> alpha changes LGTM

dnolen23:05:27

@anmonteiro thanks applied