Clojurians
#cljs-dev
<
2017-04-11
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

thheller11:04:15

it only prevents some comments from being emitted? why not always emit them?

thheller11:04:44

I was tracking down why multi-arity/variadic fn did emit the @param {...*} var_args jsdoc but defn didn't

thheller11:04:04

the one for defn is behind the check, the fn one isn't

dnolen14:04:53

@thheller it shouldn’t do that, bug if it does

thheller15:04:38

@dnolen just so I understand correctly: that variadic fn emits a var_args jsdoc even with :check-types :off is the bug?

dnolen15:04:41

@thheller I don’t know, what do you think the problem is, and more importantly why does it matter? :slightly_smiling_face:

thheller15:04:44

I'm looking to enable :check-types again, just going through each warning I encounter

thheller15:04:02

I used {:check-types :warning} which the above method doesn't recognise (expects :warn which is incorrect), so variadic defn never hard the proper var_args annotation

thheller15:04:10

causing closure to complain a lot

thheller15:04:53

never really looked into the :check-types things before but I have a goal in mind which I need it for

thheller15:04:28

so it matters that {:check-types :warning} isn't recognized in the comp/checking-types? fn above

thheller15:04:43

as the var_args jsdoc is important

dnolen15:04:13

I would consider :check-types a dead end for now

dnolen15:04:44

whatever it becomes it should be tied into spec and how it works should be considered details

thheller15:04:10

yeah I'm getting that impression. Closure doesn't like the protocol dispatch it seems. WARNING - Property cljs$core$IHash$ never defined on o

thheller15:04:03

the issue is that Closure uses the type annotations for :advanced

thheller15:04:41

but still figuring this out

thheller15:04:48

it does find some semi-useful things though

thheller15:04:49

WARNING - Function cljs.core.PersistentHashSet.createAsIfByAssoc: called with 2 argument(s). Function requires at least 1 argument(s) and no more than 1 argument(s).

thheller16:04:52

WARNING - Function cljs.core.PersistentArrayMap.createAsIfByAssoc: called with 3 argument(s). Function requires at least 1 argument(s) and no more than 1 argument(s).

thheller16:04:43

js doesn't care about the dead arguments but still ...

dnolen16:04:15

@thheller I agree it’s useful, but I just want it to be more idiomatic via spec integration

thheller16:04:00

yeah I'm more concerned about :advanced not properly handling some renames

thheller16:04:37

not intending to typecheck really, just looking if some extra type annotations could enable an idea I had for :infer-externs

anmonteiro23:04:25

for everyone out there suffering from the Closure Compiler async bug, http://dev.clojure.org/jira/browse/CLJS-2006

anmonteiro23:04:34

they released a new version, v20170409