Just replaced the patch in http://dev.clojure.org/jira/browse/CLJS-1960 with one containing this fix ^ /cc @spinningtopsofdoom

I wonder if this is only place where full analyze result is included in warning extra data: https://github.com/clojure/clojurescript/blob/a3a242236e7757a179fd16dd9b86767a73a8cb5d/src/main/clojure/cljs/analyzer.cljc#L2823

I hit problems in boot-cljs as I need to move the warning data between classpaths and printing that value doesn't seem to work

specifically it is analyze result :env which is unprintable (perhaps it is just very large, or maybe it contains some circular references)

@juhoteperi yeah :env can have a lot of redundant info (there may be cases where it’s circular but I don’t remember)

For now I fixed this by dissocing :env from :fexpr (in boot-cljs)

I wonder if it would make sense to change :fn-deprecated and :invoke-ctor extra data from analyze result to only include :info?

@anmonteiro With the new patch I can't run module_deps.js since Object.values is not available for node v6.10.0 but is available for v7.7.1

The fix you made works once Object.valuesis worked around

@spinningtopsofdoom ah interesting, I didn't know about that Object.values limitation

I can get that fixed, we definitely wanna support Node.js v6.x

@spinningtopsofdoom the patch in http://dev.clojure.org/jira/browse/CLJS-1960 should now be Node v.6.x compatible!

as always, any feedback appreciated

Works for me with node v6+ and a mixture of manual dependencies and npm-deps. Great job, thanks for all your work.

that’s awesome!

@spinningtopsofdoom just deployed a little performance optimization to the patch, would you mind testing it’s still backwards compatible to Node v6?

by “deployed” I mean attached a new patch to CLJS-1960

Sure testing right now

It still works

@anmonteiro ^^^

🎉

great. I’m quite satisfied with where the patch is at right now

I’d say

and then I'd work on the upstream deps.cljs integration during the weekend

@anmonteiro is this also taking into consideration the npm "browser" issue ?

yes

I fixed that yesterday I think

or the day before

ok so I'll try it again on the repro repl thanks!

@richiardiandrea you’ll probably get a Closure Compiler error with aws-sdk. https://github.com/google/closure-compiler/issues/2345

if you can narrow it down, I appreciate it

for me it has only ever happened with that package, which is huge

Yeah that is why I wanted to try it 😀

yeah, any help narrowing that one down appreciated