Clojurians
#cljs-dev
<
2017-03-03
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

anmonteiro00:03:09

Just replaced the patch in http://dev.clojure.org/jira/browse/CLJS-1960 with one containing this fix ^ /cc @spinningtopsofdoom

juhoteperi12:03:17

I hit problems in boot-cljs as I need to move the warning data between classpaths and printing that value doesn't seem to work

juhoteperi12:03:50

specifically it is analyze result :env which is unprintable (perhaps it is just very large, or maybe it contains some circular references)

dnolen13:03:14

@juhoteperi yeah :env can have a lot of redundant info (there may be cases where it’s circular but I don’t remember)

juhoteperi13:03:12

For now I fixed this by dissocing :env from :fexpr (in boot-cljs)

juhoteperi13:03:43

I wonder if it would make sense to change :fn-deprecated and :invoke-ctor extra data from analyze result to only include :info?

spinningtopsofdoom16:03:03

@anmonteiro With the new patch I can't run module_deps.js since Object.values is not available for node v6.10.0 but is available for v7.7.1

spinningtopsofdoom17:03:12

The fix you made works once Object.valuesis worked around

anmonteiro17:03:58

@spinningtopsofdoom ah interesting, I didn't know about that Object.values limitation

anmonteiro17:03:13

I can get that fixed, we definitely wanna support Node.js v6.x

anmonteiro19:03:14

@spinningtopsofdoom the patch in http://dev.clojure.org/jira/browse/CLJS-1960 should now be Node v.6.x compatible!

anmonteiro19:03:28

as always, any feedback appreciated

spinningtopsofdoom19:03:35

Works for me with node v6+ and a mixture of manual dependencies and npm-deps. Great job, thanks for all your work.

anmonteiro19:03:17

that’s awesome!

anmonteiro19:03:20

@spinningtopsofdoom just deployed a little performance optimization to the patch, would you mind testing it’s still backwards compatible to Node v6?

anmonteiro19:03:28

by “deployed” I mean attached a new patch to CLJS-1960

spinningtopsofdoom19:03:44

Sure testing right now

anmonteiro19:03:53

great. I’m quite satisfied with where the patch is at right now

anmonteiro19:03:02

I’d say :shipit:

anmonteiro19:03:31

and then I'd work on the upstream deps.cljs integration during the weekend

richiardiandrea20:03:09

@anmonteiro is this also taking into consideration the npm "browser" issue ?

anmonteiro20:03:30

I fixed that yesterday I think

anmonteiro20:03:32

or the day before

richiardiandrea20:03:33

ok so I'll try it again on the repro repl thanks!

anmonteiro20:03:45

@richiardiandrea you’ll probably get a Closure Compiler error with aws-sdk. https://github.com/google/closure-compiler/issues/2345

anmonteiro20:03:54

if you can narrow it down, I appreciate it

anmonteiro20:03:03

for me it has only ever happened with that package, which is huge

richiardiandrea20:03:20

Yeah that is why I wanted to try it :grinning:

anmonteiro20:03:02

yeah, any help narrowing that one down appreciated