Fork me on GitHub
#cljs-dev
<
2017-02-25
>
rmuslimov04:02:20

I just checked import feature I was waiting for. it works in latest release! awesome, thanks guys!

dnolen19:02:48

@rmuslimov you mean ES6 import w/ Node.js resolution?

darwin20:02:01

it works under .473, so it must be related to Feb2017 closure update

darwin20:02:04

BOOM! the generated code uses async name as variable/function name, but in ES6/ES2017 it has special meaning[1] [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function we will have to add it into js-reserved-arr I guess

rmuslimov20:02:15

@dnolen I meant import like import {foo, bar} from './utils’;, AFAIU node.js import resolution is not supported for now.

darwin21:02:32

I’m experimenting with a fix, adding async into js-reserved in analyzer.cljc and js-reserved-arrof core.cljs creates another problem, it munges goog.async namespace as well, which is unwanted in this case, it breaks code like this: https://github.com/clojure/core.async/blob/master/src/main/clojure/cljs/core/async/impl/dispatch.cljs#L29