This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-02-05
Channels
- # bangalore-clj (2)
- # beginners (132)
- # boot (311)
- # cider (5)
- # cljs-dev (27)
- # cljsjs (2)
- # cljsrn (16)
- # clojure (76)
- # clojure-art (1)
- # clojure-france (8)
- # clojure-russia (35)
- # clojure-spain (3)
- # clojure-spec (2)
- # clojure-uk (11)
- # clojureindia (1)
- # clojurescript (98)
- # core-async (3)
- # css (9)
- # cursive (9)
- # datascript (7)
- # datomic (7)
- # emacs (30)
- # jobs (1)
- # lein-figwheel (7)
- # london-clojurians (1)
- # lumo (14)
- # off-topic (6)
- # om (1)
- # planck (3)
- # protorepl (1)
- # re-frame (27)
- # reagent (17)
- # spacemacs (10)
- # untangled (1)
- # yada (16)
@juhoteperi: holy cow! That's sweet!
Any comments about naming or the API?
@juhoteperi: thanks!!
@dnolen I get a bunch of closure warnings with 456. I assume that is why you disable the type checking?
https://github.com/clojure/clojurescript/commit/367e2fb600c54d3b04a1d85ccf9bc659b7f05151
WARNING: CLJS/cljs/spec/impl/gen.js:2103: WARNING - Function cljs.core.array_seq: called with 2 argument(s). Function requires at least 1 argument(s) and no more than 1 argument(s).
return cljs.spec.impl.gen.elements.cljs$core$IFn$_invoke$arity$variadic(cljs.core.array_seq([pred], 0));
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Looks like Closure can't currently resolve Common JS modules from classpath and there seems to be problems even using relative paths
@juhoteperi: Closure doesn't use the classpath for resolution at all
Okay. I'm interested in supporting that as I want to package npm packages into Cljsjs.
Well, I'll have to investigate if this is something that could be changed in Closure or if it can be worked around in Cljs or tooling side.
Btw. @dnolen Did you see https://github.com/cljsjs/packages/tree/master/babel-standalone ? Should the module guide on Cljs site be updated to use or mention this?
@juhoteperi: if you have new instructions happy to review a PR.
Okay, I'll create a PR. I'll also start thinking about providing Nodejs and other missing externs in Cljsjs.
As all externs provided by a package are always enabled, I wonder if it is better to package each Nodejs extern separately or provide single Nodejs externs package.
Hmm, Closure-compiler itself also provides set of Nodejs externs: https://github.com/google/closure-compiler/tree/master/contrib/nodejs
@juhoteperi: been thinking about babel-standalone. If the presets key uses the full namespace tooling can try to resolve/require it dynamically.
Yeah I thought about something like that
I guess it is something that Cljs shouldn't do but boot-cljs or figwheel could do
I should either rename the namespace to cljsjs.babel
or the key to :cljsjs/babel-standalone
or hmm, the keyword namespace should be cljsjs.babel-standalone
so key could be :cljsjs.babel-standalone/babel