Clojurians
#cljs-dev
<
2017-02-05
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

bhauman00:02:47

@juhoteperi: holy cow! That's sweet!

juhoteperi00:02:09

Any comments about naming or the API?

bhauman00:02:28

The naming seems pretty good to me. This is new ground so it's tough to know.

bhauman00:02:49

Overall I think it's perfect for now.

bhauman00:02:08

@juhoteperi: thanks!!

thheller10:02:09

@dnolen I get a bunch of closure warnings with 456. I assume that is why you disable the type checking?

thheller10:02:32

WARNING: CLJS/cljs/spec/impl/gen.js:2103: WARNING - Function cljs.core.array_seq: called with 2 argument(s). Function requires at least 1 argument(s) and no more than 1 argument(s).
return cljs.spec.impl.gen.elements.cljs$core$IFn$_invoke$arity$variadic(cljs.core.array_seq([pred], 0));
                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

thheller10:02:10

did you think about how we can teach variadic fns to closure?

thheller10:02:47

(before I start to dive into the type checking stuff myself)

juhoteperi11:02:48

Looks like Closure can't currently resolve Common JS modules from classpath and there seems to be problems even using relative paths

dnolen15:02:46

@thheller: only seemed to happen under code splitting but yes

dnolen15:02:29

@juhoteperi: Closure doesn't use the classpath for resolution at all

juhoteperi15:02:27

Okay. I'm interested in supporting that as I want to package npm packages into Cljsjs.

juhoteperi15:02:57

Well, I'll have to investigate if this is something that could be changed in Closure or if it can be worked around in Cljs or tooling side.

juhoteperi15:02:23

Btw. @dnolen Did you see https://github.com/cljsjs/packages/tree/master/babel-standalone ? Should the module guide on Cljs site be updated to use or mention this?

dnolen15:02:43

@juhoteperi: if you have new instructions happy to review a PR.

juhoteperi15:02:27

Okay, I'll create a PR. I'll also start thinking about providing Nodejs and other missing externs in Cljsjs.

juhoteperi15:02:09

As all externs provided by a package are always enabled, I wonder if it is better to package each Nodejs extern separately or provide single Nodejs externs package.

juhoteperi15:02:43

Hmm, Closure-compiler itself also provides set of Nodejs externs: https://github.com/google/closure-compiler/tree/master/contrib/nodejs

bhauman19:02:03

@juhoteperi: been thinking about babel-standalone. If the presets key uses the full namespace tooling can try to resolve/require it dynamically.

bhauman19:02:43

I'm sorry I didn't think of this yesterday

juhoteperi19:02:26

Yeah I thought about something like that

juhoteperi19:02:52

I guess it is something that Cljs shouldn't do but boot-cljs or figwheel could do

juhoteperi19:02:14

I should either rename the namespace to cljsjs.babel or the key to :cljsjs/babel-standalone

juhoteperi19:02:32

or hmm, the keyword namespace should be cljsjs.babel-standalone

juhoteperi19:02:50

so key could be :cljsjs.babel-standalone/babel