This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-01-08
Channels
- # aws (4)
- # beginners (81)
- # boot (65)
- # cljs-dev (10)
- # cljsjs (1)
- # cljsrn (12)
- # clojure (26)
- # clojure-austin (2)
- # clojure-dusseldorf (2)
- # clojure-russia (123)
- # clojure-spec (23)
- # clojure-uk (12)
- # clojurescript (36)
- # cursive (11)
- # datomic (39)
- # events (1)
- # hoplon (25)
- # incanter (4)
- # leiningen (3)
- # off-topic (5)
- # om (31)
- # re-frame (24)
- # reagent (13)
- # ring-swagger (2)
- # rum (10)
- # untangled (3)
- # yada (10)
Okay, so I'm taking a look at http://dev.clojure.org/jira/browse/CLJS-1453
And it looks like the most obvious way to fix it is to change https://github.com/clojure/clojurescript/blob/master/src/main/clojure/cljs/analyzer.cljc#L3305
But I have no idea what the ramifications of that change are.
@angusiguess I'm guessing since the order is random anyway, changing it to a vector wouldn't change much
Hi, When creating an iterator from a cljs.core.SubVec, the type of the wrapped vector is not checked. This is dangerous because RangedIterator makes assumptions on the PersistentVector internals. This also differs from the Clojure implementation: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/core.cljs#L5470 vs https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/APersistentVector.java#L565 As a consequence, cljs.core.subvec is incompatible with alternative Vector implementations Can I open a ticket for this ?
actually, the difference is that clojurescript's ranged iterator uses persistent vectors internals directly while clojure's ranged iterator only uses "nth" from Indexed
when passed a nil coll, clojurescript's assoc returns an hash-map, shouldn't be an array-map instead ?
cljs.core.MetaFn alone adds 8K of javascript code to cljs.core. It's probably rarely needed by clojurescript users. It cannot be removed by the closure compiler because cljs.core uses "with-meta" at multiple places. Almost everywhere cljs.core uses "with-meta" it could use "-with-meta" instead. By doing this, MetaFn gets removed for users who do not explicitly use "with-meta" or "vary-meta". Would a patch be considered ?