Clojurians
#cljs-dev
<
2017-01-08
>

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

angusiguess01:01:06

But I have no idea what the ramifications of that change are.

ambrosebs01:01:37

@angusiguess I'm guessing since the order is random anyway, changing it to a vector wouldn't change much

ambrosebs01:01:41

for :requires

ambrosebs01:01:02

I'd just call distinct at the end to ensure no duplicates

ewen20:01:07

Hi, When creating an iterator from a cljs.core.SubVec, the type of the wrapped vector is not checked. This is dangerous because RangedIterator makes assumptions on the PersistentVector internals. This also differs from the Clojure implementation: https://github.com/clojure/clojurescript/blob/master/src/main/cljs/cljs/core.cljs#L5470 vs https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/APersistentVector.java#L565 As a consequence, cljs.core.subvec is incompatible with alternative Vector implementations Can I open a ticket for this ?

ewen20:01:16

actually, the difference is that clojurescript's ranged iterator uses persistent vectors internals directly while clojure's ranged iterator only uses "nth" from Indexed

ewen21:01:20

when passed a nil coll, clojurescript's assoc returns an hash-map, shouldn't be an array-map instead ?

ewen22:01:46

cljs.core.MetaFn alone adds 8K of javascript code to cljs.core. It's probably rarely needed by clojurescript users. It cannot be removed by the closure compiler because cljs.core uses "with-meta" at multiple places. Almost everywhere cljs.core uses "with-meta" it could use "-with-meta" instead. By doing this, MetaFn gets removed for users who do not explicitly use "with-meta" or "vary-meta". Would a patch be considered ?