This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2016-12-22
Channels
- # adventofcode (1)
- # beginners (172)
- # boot (47)
- # cider (7)
- # cljs-dev (30)
- # cljsrn (43)
- # clojure (180)
- # clojure-dusseldorf (1)
- # clojure-greece (1)
- # clojure-italy (3)
- # clojure-russia (41)
- # clojure-spec (67)
- # clojure-uk (101)
- # clojurescript (128)
- # core-async (4)
- # cursive (13)
- # datomic (29)
- # devcards (5)
- # emacs (19)
- # events (1)
- # hoplon (38)
- # lein-figwheel (1)
- # luminus (8)
- # midje (1)
- # off-topic (47)
- # om (10)
- # onyx (23)
- # protorepl (1)
- # re-frame (11)
- # reagent (7)
- # ring (3)
- # ring-swagger (9)
- # rum (6)
- # sql (5)
- # untangled (4)
running some tests on my changes, but there's a preliminary diff if anyone has spare eyes https://github.com/frenchy64/clojurescript/pull/3/files
;;; str
[], (str 1), 1000000 runs, 96 msecs
[], (str nil), 1000000 runs, 80 msecs
[], (str "1"), 1000000 runs, 86 msecs
[], (str "1" "2"), 1000000 runs, 123 msecs
[], (str "1" "2" "3"), 1000000 runs, 160 msecs
;;; bstr
[], (bstr/str 1), 1000000 runs, 0 msecs
[], (bstr/str nil), 1000000 runs, 0 msecs
[], (bstr/str "1"), 1000000 runs, 0 msecs
[], (bstr/str "1" "2"), 1000000 runs, 0 msecs
[], (bstr/str "1" "2" "3"), 1000000 runs, 0 msecs
finally decided it was time to revisit http://dev.clojure.org/jira/browse/CLJS-890
@dnolen I want to create a new JIRA issue to fix a glaring oversight with regards to str
performance but there is not benchmark for it yet
should I create a seperate patch for the benchmark itself so it can be run against the "old" impl
(the new benchmark is 0 because it is dead code eliminated, while the current str
impl never is)
;; str
[], (str 1), 1000000 runs, 55 msecs
[], (str nil), 1000000 runs, 39 msecs
[], (str "1"), 1000000 runs, 44 msecs
[], (str "1" "2"), 1000000 runs, 257 msecs
[], (str "1" "2" "3"), 1000000 runs, 334 msecs
;;; bstr
[], (bstr/str 1), 1000000 runs, 13 msecs
[], (bstr/str nil), 1000000 runs, 8 msecs
[], (bstr/str "1"), 1000000 runs, 11 msecs
[], (bstr/str "1" "2"), 1000000 runs, 173 msecs
[], (bstr/str "1" "2" "3"), 1000000 runs, 210 msecs
nvm I guess, the patch is so straightforward .. no need to make it any more complicated
@ambrosebs failing under SM is not a high priority (if you’re using a nightly or something)
@dnolen actually it was Nashorn that failed http://pastebin.com/CQkHLh67
@ambrosebs Nashorn we care about even less
@dnolen here's the patch for some? and ^boolean tags in the analyzer http://dev.clojure.org/jira/browse/CLJS-1878
@ambrosebs thanks!