@favila symptom not the cause 🙂

I know, but I am not sure what is expected, not sure what issue to file

could be either: 1) data_readers should auto-require (not sure if true), 2) data_readers.cljc from tests should not be on classpath for benchmark (seems likely), 3) ns should require anything its data readers need

no to 1)

2) is a problem but doesn’t fix the underlying issue

3) is just how it’s supposed to work

@anmonteiro https://github.com/clojure/clojurescript/commit/0ec11d2f18672949614b890b5f3002a939e35a88, not sure how you were testing the data readers functionality but this should fix actual problem

benchmarks can run again now

@dnolen if 3, then doesn't cljs.tagged-literals-test need to require clojure.set?

yes

@favila well technically it should - but not 100% necessary in this case since other tests load it

correct

@dnolen: probably didn't produce an error because any library the data reader tests relied on was in the compiler state

that's why test doesn't fail

Which you already said above. Hah, sorry, on phone

that data_readers.cljc got on the classpath worries me. Makes me wonder if aot cljs jar includes tests too

ok, benchmark includes tests in its classpath just because that's what bin/cljsc does

and benchmark invokes it

@favila: right, I dont think the uberjar includes them

@anmonteiro double checked, yes aot is fine

so nm

@bja not much shorter, but java -cp cljs.jar:src clojure.main -m cljs.repl.nashorn

don't know if its worth making bin/cljsc have test/non-test distinction, benchmark is the only non-test invocation

oops wrong channel